Review main Merged

75023[DOCS] Fix outdated TypoScript sample

TYPO3com CR +2 V +2 Easy +1 −1 updated 07/04/22, 14:49

Commit message

Use new Symfony TypoScript condition syntax instead
of outdated syntax.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Oliver Klee +1
    • Björn Jacob +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Oliver Klee +1
    • Björn Jacob +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1116

  1. TYPO3com uploaded patch set 1 07/03/22, 12:39

  2. core-ci voted on patch set 1 V +1 07/03/22, 12:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28622

  3. Simon Schaufelberger commented on patch set 1 07/03/22, 19:03

    I guess this can also be backported
  4. Oliver Klee voted on patch set 1 V +1 CR +1 07/03/22, 19:06

  5. Simon Schaufelberger updated the commit message in patch set 2 07/03/22, 20:38

  6. Simon Schaufelberger updated the commit message in patch set 3 07/03/22, 20:41

  7. Simon Schaufelberger updated the commit message in patch set 4 07/03/22, 20:42

  8. core-ci voted on patch set 3 V +1 07/03/22, 20:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28624

  9. core-ci voted on patch set 4 V +1 07/03/22, 20:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28625

  10. core-ci voted on patch set 2 V +1 07/03/22, 20:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28623

  11. Oliver Klee voted on patch set 4 V +1 CR +1 07/03/22, 21:26

  12. Simon Schaufelberger voted on patch set 4 V +1 CR +1 07/03/22, 22:04

  13. Georg Ringer voted on patch set 4 V +1 CR +1 07/04/22, 04:40

  14. Björn Jacob voted on patch set 4 V +1 CR +1 07/04/22, 11:13

  15. Benni Mack voted on patch set 4 V +2 CR +2 07/04/22, 14:49

  16. Benni Mack merged patch set 5 07/04/22, 14:49