75028[BUGFIX] Cast folder name in tree provider to string
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Oliver Klee +1
- Stefan Bürk +1
- Nikita Hovratov +1
- Simon Schaufelberger +1
-
Verified V +2 Done
- Andreas Kienast +2
- Stefan Bürk +1
- Nikita Hovratov +1
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1620
-
Andreas Kienast uploaded patch set 1 07/04/22, 20:34
-
Andreas Kienast uploaded patch set 2 07/04/22, 20:35
-
core-ci voted on patch set 1 V +1 07/04/22, 20:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28638
-
core-ci voted on patch set 2 V +1 07/04/22, 20:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28639
-
Stefan Bürk commented on patch set 2 07/04/22, 21:01
-
Andreas Kienast commented on patch set 2 07/04/22, 21:03
FileStorageTreeProvider.php:212ReplyAck -
Andreas Kienast uploaded patch set 3 07/04/22, 21:05
-
Oliver Klee voted on patch set 3 CR +1 07/04/22, 21:11
-
core-ci voted on patch set 3 V +1 07/04/22, 21:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28640
-
Simon Schaufelberger updated the commit message in patch set 4 07/04/22, 23:26
-
Simon Schaufelberger voted on patch set 4 V +1 CR +1 07/04/22, 23:27
-
core-ci voted on patch set 4 V +1 07/04/22, 23:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28643
-
Simon Schaufelberger commented on patch set 4 07/04/22, 23:42
This class doesn't have any tests yet. Would you be willing to create a test that covers at least the getSubfoldersRecursively method? -
Andreas Kienast commented on patch set 4 07/05/22, 06:40
Reply Unresolved
I can give it a try, but that will take some time. -
Nikita Hovratov voted on patch set 4 V +1 CR +1 07/05/22, 06:57
-
Stefan Bürk voted on patch set 4 V +1 CR +1 07/05/22, 08:22
-
Oliver Klee voted on patch set 4 CR +1 07/05/22, 09:51
-
Oliver Klee commented on patch set 4 07/05/22, 10:24
I have created https://review.typo3.org/c/Packages/TYPO3.CMS/+/75033 to fix the root cause (or the incorrect annotations) of this bug. -
Andreas Kienast voted on patch set 4 V +2 CR +2 07/05/22, 18:10
-
Andreas Kienast merged patch set 5 07/05/22, 18:11
FileStorageTreeProvider.php:212