Review main Merged

75033[BUGFIX] Fix type annotations concerning storage folder identifiers

Oliver Klee CR +2 V +2 Easy +12 −11 updated 07/07/22, 19:38

Commit message

Storage folder identifiers can also be int-like strings, which causes
them to automatically get cast to int when used as array keys.

Our types annotations need to reflect this in order to keep developers
and static analysis for taking those array keys to be always strings
(which can lead to type errors and has recently done so).

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Nikita Hovratov +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Nikita Hovratov +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 1217

  1. Oliver Klee uploaded patch set 1 07/05/22, 10:15

  2. core-ci voted on patch set 1 V -1 07/05/22, 10:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28657

  3. Oliver Klee commented on patch set 1 CR -1 07/05/22, 10:25

    Note: We should to merge the bug fix https://review.typo3.org/c/Packages/TYPO3.CMS/+/75028 first, and we absolutely need to merge https://review.typo3.org/c/Packages/TYPO3.CMS/+/75034 first (and then I'll need to rebase) so we can get this change here to work without PHPStan (rightfully) being very unhappy.
  4. Oliver Klee uploaded patch set 2 07/05/22, 21:03

  5. Oliver Klee commented on patch set 2 CR -1 07/05/22, 21:03

  6. core-ci voted on patch set 2 V +1 07/05/22, 21:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28682

  7. Oliver Klee uploaded patch set 3 07/07/22, 15:18

  8. core-ci voted on patch set 3 V +1 07/07/22, 15:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28718

  9. Oliver Klee updated the commit message in patch set 4 07/07/22, 16:07

  10. core-ci voted on patch set 4 V +1 07/07/22, 16:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28722

  11. Nikita Hovratov uploaded patch set 5 07/07/22, 18:48

  12. Nikita Hovratov voted on patch set 5 V +1 CR +1 07/07/22, 18:48

  13. core-ci voted on patch set 5 V +1 07/07/22, 18:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28727

  14. Simon Schaufelberger voted on patch set 5 V +1 CR +1 07/07/22, 18:59

  15. Oliver Klee commented on patch set 5 07/07/22, 19:04

    Thanks for the typo fix, Nikita!
  16. Stefan Bürk voted on patch set 5 V +2 CR +2 07/07/22, 19:36

  17. Stefan Bürk merged patch set 6 07/07/22, 19:38