Review main Merged

75036[TASK] Move Page Title Generation for search out of TSFE

Benni Mack CR +2 V +2 Normal +7 −53 updated 07/05/22, 14:07

Commit message

This change removes the internal property "indexedDocTitle"
which is filled by the PageTitleProvider API.

This API is then moved to Indexed Search to use the same logic
to fetch the "real" page title (without site title etc)
when a plugin is registered.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 68

  1. Benni Mack uploaded patch set 1 07/05/22, 11:05

  2. core-ci voted on patch set 1 V +1 07/05/22, 11:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28662

  3. Benni Mack updated the commit message in patch set 2 07/05/22, 12:44

  4. core-ci voted on patch set 2 V +1 07/05/22, 12:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28672

  5. Oli Bartsch voted on patch set 2 V +1 CR +1 07/05/22, 13:41

  6. Andreas Kienast voted on patch set 2 CR +1 07/05/22, 14:03

  7. Andreas Kienast voted on patch set 2 V +2 CR +2 07/05/22, 14:07

  8. Andreas Kienast merged patch set 3 07/05/22, 14:07