Review main Abandoned

75038[BUGFIX] Remove duplicated pages in mountpoints

Silvia Bigler CR 0 V 0 Easy +8 −0 updated 07/09/22, 19:09

Commit message

Fix duplicated pages when multiple mountpoints are used

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 45

  1. Silvia Bigler uploaded patch set 1 07/05/22, 11:43

  2. core-ci voted on patch set 1 V -1 07/05/22, 12:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28665

  3. Nikita Hovratov commented on patch set 1 07/05/22, 12:05

    Have a look at this patch: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74258 It seems to solve the same issue.
  4. Stefan Bürk commented on patch set 1 07/09/22, 19:08

    Thanks Silvia for this patch. There has been duplicated issue on forge. This patch has some errors, but it seems the "thought fix" goes in the same direction like the patch and fix from Nikita: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74258 I will abandon this patch in favor of the other patch, as this does not only work - it also includes proper testcases for it to avoid a regression in the future and is the more developed patch. Makes more sense to go for it instead of re-adding all the stuff here. Hope that's fine for you. Would be nice if you could look into the other patch and try it out (verify) that it fixes it for you too.
  5. Stefan Bürk abandoned the change 07/09/22, 19:09

    Abandon in favor of more developed duplicate patch https://review.typo3.org/c/Packages/TYPO3.CMS/+/74258 which has proper tests and is working so far.