Review main Merged Breaking

75039[!!!][FEATURE] Introduce PSR-14 events when storing cached content in frontend

Benni Mack CR +2 V +2 Hard +394 −84 updated 07/07/22, 19:29

Commit message

This change adds two new PSR-14 Events

* \TYPO3\CMS\Frontend\Event\AfterCacheableContentIsGeneratedEvent
* \TYPO3\CMS\Frontend\Event\AfterCachedPageIsPersistedEvent

which replace
$GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tslib/class.tslib_fe.php']['contentPostProc-cached']
$GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tslib/class.tslib_fe.php']['contentPostProc-all']
and
$GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tslib/class.tslib_fe.php']['usePageCache']
$GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tslib/class.tslib_fe.php']['insertPageIncache']
hooks.

Those hooks were much important and powerful, receiving
even more power by the new Events, which allow manipulating
content stored in cache, or when a page was cached in the
Frontend.

Additionally, the TSFE->generatePage_postProcessing() method
does now require a ServerRequestInterface as first paramter,
to be able to pass the current request to the new events.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Stefan Bürk +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 11

Review log 2028

Show 23 earlier messages
  1. Benni Mack uploaded patch set 1 07/05/22, 11:44

  2. core-ci voted on patch set 1 V +1 07/05/22, 11:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28666

  3. Benni Mack uploaded patch set 2 07/05/22, 12:42

  1. Benni Mack updated the commit message in patch set 3 07/05/22, 12:48

  2. core-ci voted on patch set 2 V +1 07/05/22, 12:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28671

  3. core-ci voted on patch set 3 V +1 07/05/22, 12:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28673

  4. Benni Mack uploaded patch set 4 07/05/22, 15:38

  5. core-ci voted on patch set 4 V -1 07/05/22, 15:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28676

  6. Benni Mack uploaded patch set 5 07/07/22, 12:31

  7. core-ci voted on patch set 5 V +1 07/07/22, 12:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28711

  8. Stefan Bürk updated the commit message in patch set 6 07/07/22, 14:15

  9. core-ci voted on patch set 6 V +1 07/07/22, 14:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28712

  10. Stefan Bürk voted on patch set 6 CR +1 07/07/22, 14:23

  11. Stefan Bürk voted on patch set 6 V +1 07/07/22, 14:49

  12. Oli Bartsch uploaded patch set 7 07/07/22, 17:09

  13. Oli Bartsch voted on patch set 7 V +1 CR +1 07/07/22, 17:10

  14. Stefan Bürk voted on patch set 7 CR +1 07/07/22, 17:14

  15. Stefan Bürk voted on patch set 7 V +1 07/07/22, 17:14

  16. core-ci voted on patch set 7 V +1 07/07/22, 17:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28723

  17. Nikita Hovratov commented on patch set 7 07/07/22, 18:00

    FrontendGenerationPageIndexingTrigger.php:18

    Should we move this class to the sub-directory EventListener? Would make it clearer that this is a PSR-14 event listener.
  18. Oli Bartsch uploaded patch set 8 07/07/22, 19:17

  19. Oli Bartsch commented on patch set 8 V +1 CR +1 07/07/22, 19:17

    FrontendGenerationPageIndexingTrigger.php:18 Reply

    Done
  20. core-ci voted on patch set 8 V +1 07/07/22, 19:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28728

  21. Stefan Bürk voted on patch set 8 V +1 CR +1 07/07/22, 19:26

  22. Nikita Hovratov voted on patch set 8 CR +1 07/07/22, 19:26

  23. Nikita Hovratov commented on patch set 8 07/07/22, 19:27

    FrontendGenerationPageIndexingTrigger.php:18 Reply

    Thanks!
  24. Benni Mack voted on patch set 8 V +2 CR +2 07/07/22, 19:29

  25. Benni Mack merged patch set 9 07/07/22, 19:29