75040[TASK] Deprecate various public TSFE properties
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Stefan Bürk +1
-
Verified V +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 12
- typo3/sysext/core/Documentation/Changelog/12.0/Deprecation-97866-VariousPublicTSFEProperties.rstnew+48 −0
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php2+27 −11
- typo3/sysext/frontend/Classes/Http/RequestHandler.php+3 −2
- typo3/sysext/frontend/Classes/Typolink/EmailLinkBuilder.php+7 −3
- typo3/sysext/frontend/Classes/Typolink/ExternalUrlLinkBuilder.php+1 −1
- typo3/sysext/frontend/Classes/Typolink/FileOrFolderLinkBuilder.php+1 −1
- typo3/sysext/frontend/Classes/Typolink/LegacyLinkBuilder.php+2 −2
- typo3/sysext/frontend/Classes/Typolink/PageLinkBuilder.php+2 −2
- typo3/sysext/frontend/Tests/Functional/ContentObject/ContentObjectRendererTest.php+1 −1
- typo3/sysext/frontend/Tests/Unit/ContentObject/ContentObjectRendererTest.php+2 −3
- typo3/sysext/frontend/Tests/Unit/Controller/TypoScriptFrontendControllerTest.php+1 −1
- typo3/sysext/install/Configuration/ExtensionScanner/Php/PropertyPublicMatcher.php+25 −0
Review log 1320
-
Benni Mack uploaded patch set 1 07/05/22, 15:30
-
core-ci voted on patch set 1 V +1 07/05/22, 15:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28675
-
Benni Mack uploaded patch set 2 07/07/22, 08:56
-
core-ci voted on patch set 2 V +1 07/07/22, 09:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28701
-
Benni Mack uploaded patch set 3 07/07/22, 09:27
-
core-ci voted on patch set 3 V +1 07/07/22, 09:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28702
-
Benni Mack uploaded patch set 4 07/07/22, 10:38
-
Benni Mack updated the commit message in patch set 5 07/07/22, 10:38
-
Benni Mack commented on patch set 6 07/07/22, 10:39
Published edit on patch set 5. -
core-ci voted on patch set 5 V +1 07/07/22, 10:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28706
-
core-ci voted on patch set 6 V +1 07/07/22, 10:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28707
-
core-ci voted on patch set 4 V +1 07/07/22, 10:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28705
-
Stefan Bürk commented on patch set 6 07/07/22, 10:53
TypoScriptFrontendController.php:100Invalid example - should we not display the deprecation message with a proper valid example instead ? ``` .... $TSFE->config[\'config\'][\'intTarget\'] ... ``` same for other messages below. What do you think ? -
Benni Mack commented on patch set 7 07/07/22, 10:56
Published edit on patch set 6. -
Benni Mack commented on patch set 7 07/07/22, 10:56
TypoScriptFrontendController.php:100ReplyDone -
core-ci voted on patch set 7 V +1 07/07/22, 11:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28708
-
Stefan Bürk voted on patch set 7 V +1 CR +1 07/07/22, 11:22
-
Oli Bartsch voted on patch set 7 V +1 CR +1 07/07/22, 11:43
-
Benni Mack voted on patch set 7 V +2 CR +2 07/07/22, 11:57
-
Benni Mack merged patch set 8 07/07/22, 11:57