Review main Merged

75040[TASK] Deprecate various public TSFE properties

Benni Mack CR +2 V +2 Normal +120 −27 updated 07/07/22, 11:57

Commit message

Various properties can be accessed directly via
TypoScript config settings.

* $TSFE->spamProtectEmailAddresses
* $TSFE->intTarget
* $TSFE->extTarget
* $TSFE->fileTarget
* $TSFE->baseUrl

They have been marked as deprecated.

In addition, some internal functionality is now
marked as @internal as well, somehow related to
the deprecated properties.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 12

Review log 1320

  1. Benni Mack uploaded patch set 1 07/05/22, 15:30

  2. core-ci voted on patch set 1 V +1 07/05/22, 15:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28675

  3. Benni Mack uploaded patch set 2 07/07/22, 08:56

  4. core-ci voted on patch set 2 V +1 07/07/22, 09:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28701

  5. Benni Mack uploaded patch set 3 07/07/22, 09:27

  6. core-ci voted on patch set 3 V +1 07/07/22, 09:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28702

  7. Benni Mack uploaded patch set 4 07/07/22, 10:38

  8. Benni Mack updated the commit message in patch set 5 07/07/22, 10:38

  9. Benni Mack commented on patch set 6 07/07/22, 10:39

    Published edit on patch set 5.
  10. core-ci voted on patch set 5 V +1 07/07/22, 10:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28706

  11. core-ci voted on patch set 6 V +1 07/07/22, 10:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28707

  12. core-ci voted on patch set 4 V +1 07/07/22, 10:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28705

  13. Stefan Bürk commented on patch set 6 07/07/22, 10:53

    TypoScriptFrontendController.php:100

    Invalid example - should we not display the deprecation message with a proper valid example instead ? ``` .... $TSFE->config[\'config\'][\'intTarget\'] ... ``` same for other messages below. What do you think ?
  14. Benni Mack commented on patch set 7 07/07/22, 10:56

    Published edit on patch set 6.
  15. Benni Mack commented on patch set 7 07/07/22, 10:56

    TypoScriptFrontendController.php:100 Reply

    Done
  16. core-ci voted on patch set 7 V +1 07/07/22, 11:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28708

  17. Stefan Bürk voted on patch set 7 V +1 CR +1 07/07/22, 11:22

  18. Oli Bartsch voted on patch set 7 V +1 CR +1 07/07/22, 11:43

  19. Benni Mack voted on patch set 7 V +2 CR +2 07/07/22, 11:57

  20. Benni Mack merged patch set 8 07/07/22, 11:57