Review main Merged

75041[TASK] Replace FontAwesome icons with typo3 icons

Andreas Kienast CR +2 V +2 Expert +607 −488 updated 08/11/22, 13:06

Commit message

To provide a consistent look&feel and to eventually phase out
FontAwesome in the TYPO3 backend, all remaining fa-* icons are replaced
with their counterparts from the @typo3/icons package.

The CSS class `icon-emphasized` is introduced as a drop-in replacement
for the `fa-stack` construct:

```
<span class="icon-emphasized">
    <core:icon identifier="my-icon-identifier" size="small"/>
</span>
```

The removal of the FontAwesome integration will follow in a separate
patch.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Benni Mack +2
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 66

Show 46 more files

Review log 72110

Show 5385 earlier messages
  1. Andreas Kienast uploaded patch set 1 07/05/22, 19:39

  2. core-ci voted on patch set 1 V -1 07/05/22, 19:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28680

  3. Andreas Kienast uploaded patch set 2 07/05/22, 20:00

  4. core-ci voted on patch set 2 V -1 07/05/22, 20:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28681

  5. Benni Mack commented on patch set 2 07/05/22, 20:30

    This is great! Thank you!
  6. Andreas Kienast uploaded patch set 3 07/06/22, 05:59

  7. core-ci voted on patch set 3 V -1 07/06/22, 06:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28688

  8. Andreas Kienast uploaded patch set 4 07/08/22, 07:03

  9. core-ci voted on patch set 4 V -1 07/08/22, 07:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28739

  10. Andreas Kienast uploaded patch set 5 07/08/22, 08:16

  11. Andreas Kienast uploaded patch set 6 07/08/22, 08:18

  12. core-ci voted on patch set 5 V -1 07/08/22, 08:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28743

  13. core-ci voted on patch set 6 V -1 07/08/22, 08:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28744

  14. Andreas Kienast uploaded patch set 7 07/08/22, 08:39

  15. core-ci voted on patch set 7 V -1 07/08/22, 08:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28745

  16. Andreas Kienast uploaded patch set 8 07/08/22, 09:58

  17. core-ci voted on patch set 8 V -1 07/08/22, 10:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28749

  18. Andreas Kienast uploaded patch set 9 07/08/22, 10:48

  19. core-ci voted on patch set 9 V -1 07/08/22, 10:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28753

  20. Andreas Kienast uploaded patch set 10 07/08/22, 13:08

  21. core-ci voted on patch set 10 V +1 07/08/22, 13:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28755

  22. Andreas Kienast uploaded patch set 11 07/08/22, 14:30

  23. core-ci voted on patch set 11 V +1 07/08/22, 14:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28761

  24. Andreas Kienast uploaded patch set 12 07/08/22, 19:21

  25. Andreas Kienast commented on patch set 12 07/08/22, 19:22

  26. core-ci voted on patch set 12 V -1 07/08/22, 19:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28770

  27. core-ci voted on patch set 12 V +1 07/08/22, 19:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28770

  28. Andreas Kienast wrote 07/08/22, 19:55

    Topic set to icons
  29. Andreas Kienast uploaded patch set 13 07/09/22, 05:13

  30. core-ci voted on patch set 13 V +1 07/09/22, 05:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28797

  31. Andreas Kienast uploaded patch set 14 07/09/22, 13:31

  32. core-ci voted on patch set 14 V +1 07/09/22, 13:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28813

  33. Nikita Hovratov voted on patch set 14 CR +1 07/10/22, 15:34

  34. Nikita Hovratov commented on patch set 14 CR 0 07/10/22, 20:25

    The Build/Sources/Sass/typo3/_element_tree.scss still uses Font Awesome. This is the one for the configuration module.

    _icons.scss:37

    suggestion: display: flex; justify-content: center; align-items: center; and kick: line-height: 2rem; vertical-align: middle; // doesn't seem to have an effect whatsoever. text-align: center;
  35. Andreas Kienast commented on patch set 14 CR -1 07/11/22, 06:05

    _icons.scss:37 Reply

    Oh boy, I didn't check for direct usages of the unicode sequences, great catch! I'll check your suggestions once I removed the remaining icons.
  36. Andreas Kienast uploaded patch set 15 07/11/22, 06:39

  37. Andreas Kienast voted on patch set 15 CR -2 07/11/22, 06:40

  38. core-ci voted on patch set 15 V +1 07/11/22, 06:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28862

  39. Andreas Kienast uploaded patch set 16 07/11/22, 08:39

  40. Andreas Kienast voted on patch set 16 CR 0 07/11/22, 08:39

  41. core-ci voted on patch set 16 V -1 07/11/22, 08:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28870

  42. Andreas Kienast uploaded patch set 17 07/11/22, 09:14

  43. Andreas Kienast commented on patch set 17 07/11/22, 09:15

    _icons.scss:37 Reply

    Works wonderful, thanks a lot!
  44. core-ci voted on patch set 17 V +1 07/11/22, 09:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28875

  45. Andreas Kienast commented on patch set 17 CR -2 07/11/22, 11:14

    Waiting for update of @typo3/icons incorporating https://github.com/TYPO3/TYPO3.Icons/pull/320.
  46. Andreas Kienast uploaded patch set 18 07/12/22, 06:39

  47. core-ci voted on patch set 18 V +1 07/12/22, 06:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28931

  48. Benjamin Kott uploaded patch set 19 07/12/22, 12:09

  49. core-ci voted on patch set 19 V -1 07/12/22, 12:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28970

  50. Andreas Kienast uploaded patch set 20 07/12/22, 13:07

  51. Andreas Kienast voted on patch set 20 CR 0 07/12/22, 13:08

  52. core-ci voted on patch set 20 V -1 07/12/22, 13:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28976

  53. Andreas Kienast uploaded patch set 21 07/12/22, 13:52

  54. core-ci voted on patch set 21 V +1 07/12/22, 14:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28980

  55. Andreas Kienast uploaded patch set 22 07/12/22, 16:57

  56. core-ci voted on patch set 22 V +1 07/12/22, 17:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28997

  57. Andreas Kienast uploaded patch set 23 07/13/22, 19:41

  58. core-ci voted on patch set 23 V +1 07/13/22, 19:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29097

  59. Andreas Kienast uploaded patch set 24 07/15/22, 05:33

  60. core-ci voted on patch set 24 V +1 07/15/22, 05:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29183

  61. Frank Nägler commented on patch set 24 CR -1 07/15/22, 09:04

    InfoboxViewHelper.php:110

    Use ContextualFeedbackSeverity here
  62. Andreas Kienast uploaded patch set 25 07/15/22, 09:13

  63. Andreas Kienast commented on patch set 25 07/15/22, 09:15

    InfoboxViewHelper.php:110 Reply

    Done
  64. core-ci voted on patch set 25 V -1 07/15/22, 09:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29193

  65. core-ci voted on patch set 25 V +1 07/15/22, 09:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29193

  66. Benni Mack voted on patch set 25 CR +1 07/15/22, 09:35

  67. Andreas Kienast commented on patch set 25 CR -2 07/15/22, 12:30

    A pre-cursor patch regarding icons in login providers will follow.
  68. Andreas Kienast uploaded patch set 26 07/16/22, 14:09

  69. Andreas Kienast voted on patch set 26 CR 0 07/16/22, 14:10

  70. core-ci voted on patch set 26 V -1 07/16/22, 14:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29285

  71. Andreas Kienast uploaded patch set 27 07/16/22, 14:28

  72. core-ci voted on patch set 27 V +1 07/16/22, 14:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29286

  73. Nikita Hovratov uploaded patch set 28 07/16/22, 20:31

  74. Nikita Hovratov commented on patch set 28 07/16/22, 20:33

    ^Replaced the element tree expand icons to look (almost) the same as before.
  75. core-ci voted on patch set 28 V +1 07/16/22, 20:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29301

  76. Nikita Hovratov uploaded patch set 29 07/16/22, 20:51

  77. core-ci voted on patch set 29 V +1 07/16/22, 21:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29304

  78. Anja Leichsenring voted on patch set 29 V +1 CR +1 07/18/22, 13:19

  79. Nikita Hovratov uploaded patch set 30 07/19/22, 07:53

  80. Nikita Hovratov commented on patch set 30 07/19/22, 07:55

    Here are some leftovers in scss that I found: Build/Sources/Sass/typo3/_icons.scss:15: &.fa { Build/Sources/Sass/typo3/_element_cropper.scss:87: &:not(.active) .fa { Build/Sources/Sass/typo3/_main_content.scss:134: .fa {
  81. Nikita Hovratov commented on patch set 30 07/19/22, 07:58

    And in Login: typo3/sysext/backend/Resources/Private/Layouts/Login.html:62: data-loading-text="<i class='fa fa-circle-o-notch fa-spin'></i> {f:translate(key: 'LLL:EXT:backend/Resources/Private/Language/locallang.xlf:login.process')}" typo3/sysext/backend/Resources/Private/Layouts/Login.html:87: <i class="fa fa-fw {provider.icon-class}"></i>
  82. core-ci voted on patch set 30 V +1 07/19/22, 08:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29350

  83. Andreas Kienast commented on patch set 30 07/19/22, 09:15

    Login.html:169

    IIRC there's action-extrrnal or alike which fits better IMO
  84. Nikita Hovratov commented on patch set 30 07/19/22, 11:33

    Login.html:169 Reply

    ah ok, go ahead and replace it
  85. Andreas Kienast commented on patch set 30 07/19/22, 19:12

    Reply

    Build/Sources/Sass/typo3/_icons.scss:15: &.fa { this is still required for now as some checkbox buttons are hacked and need more love on a broader level.
  1. Andreas Kienast uploaded patch set 31 07/19/22, 19:13

  2. core-ci voted on patch set 31 V -1 07/19/22, 19:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29366

  3. Andreas Kienast uploaded patch set 32 07/19/22, 19:22

  4. core-ci voted on patch set 32 V +1 07/19/22, 19:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29367

  5. Andreas Kienast commented on patch set 32 CR -2 07/20/22, 19:35

  6. Andreas Kienast uploaded patch set 33 07/22/22, 11:53

  7. Andreas Kienast commented on patch set 33 CR 0 07/22/22, 11:53

    The remaining `.fa` definition in Build/Sources/Sass/typo3/_icons.scss will fall with the removal of FontAwesome.
  8. core-ci voted on patch set 33 V +1 07/22/22, 12:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29426

  9. Nikita Hovratov commented on patch set 33 07/22/22, 19:58

    Login.html:87

    Did we deprecate icon-class? I can only find an Important.rst stating iconIdentifier is allowed now. This will break, when we remove FontAwesome from the backend, or what is the plan here?
  10. Andreas Kienast commented on patch set 33 07/22/22, 21:10

    Login.html:87 Reply

    Yes, this will be gone with FontAwesome.
  11. Nikita Hovratov commented on patch set 33 07/23/22, 16:01

    Login.html:87 Reply

    Ack

    Login.html:169 Reply

    Done
  12. Nikita Hovratov uploaded patch set 34 07/23/22, 16:57

  13. Nikita Hovratov voted on patch set 34 V +1 CR +1 07/23/22, 16:58

  14. core-ci voted on patch set 34 V +1 07/23/22, 17:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29455

  15. Andreas Kienast uploaded patch set 35 07/27/22, 07:01

  16. core-ci voted on patch set 35 V +1 07/27/22, 07:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29605

  17. Nikita Hovratov commented on patch set 35 V -1 07/27/22, 07:20

    We need to re-add the tree handle icons for the new object browser again.
  18. Nikita Hovratov uploaded patch set 36 07/27/22, 07:30

  19. Andreas Kienast commented on patch set 36 07/27/22, 07:36

    Thanks Nikita!
  20. core-ci voted on patch set 36 V +1 07/27/22, 07:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29606

  21. Nikita Hovratov voted on patch set 36 V +1 CR +1 07/27/22, 07:46

  22. Benni Mack voted on patch set 36 V +2 CR +2 07/27/22, 07:50

  23. Benni Mack merged patch set 37 07/27/22, 07:50

  24. Benjamin Franzke commented on patch set 37 08/11/22, 13:02

    Small additional note: As far as I know and see things, there is an additional left-over: The entire "icon-unify" class behaviour (scaling icons to 0.86) was only needed for font-awesome. So I think we could drop that as well.
  25. Andreas Kienast commented on patch set 37 08/11/22, 13:06

    Reply

    Thanks. I wanted to take another look at the remaining icon classes soon, I'll check that one as well.