75041[TASK] Replace FontAwesome icons with typo3 icons
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Nikita Hovratov +1
-
Verified V +2 Done
- Benni Mack +2
- Nikita Hovratov +1
- core-ci +1 CI
Issues 1
Files 66
- Build/Sources/Sass/component/_callout.scss+11 −14
- Build/Sources/Sass/component/_icon.scss+12 −0
- Build/Sources/Sass/libs/_chosen.scss+11 −10
- Build/Sources/Sass/typo3/_debugconsole.scss+0 −2
- Build/Sources/Sass/typo3/_element_cropper.scss+0 −4
- Build/Sources/Sass/typo3/_element_draguploader.scss+22 −11
- Build/Sources/Sass/typo3/_element_message.scss+0 −6
- Build/Sources/Sass/typo3/_element_tab.scss+8 −14
- Build/Sources/Sass/typo3/_element_tree.scss+8 −22
- Build/Sources/Sass/typo3/_icons.scss3+12 −0
- Build/Sources/Sass/typo3/_login_screen.scss+1 −4
- Build/Sources/Sass/typo3/_main_backend_layout_wizard.scss+129 −106
- Build/Sources/Sass/typo3/_main_content.scss+0 −5
- Build/Sources/Sass/typo3/_main_form.scss+7 −6
- Build/Sources/Sass/form.scss+8 −13
- Build/Sources/TypeScript/backend/tests/notification-test.ts+5 −0
- Build/Sources/TypeScript/backend/debug-console.ts+12 −12
- Build/Sources/TypeScript/backend/form-engine-review.ts+2 −1
- Build/Sources/TypeScript/backend/grid-editor.ts+62 −63
- Build/Sources/TypeScript/backend/localization.ts+2 −1
Show 46 more files
- Build/Sources/TypeScript/backend/notification.ts+9 −9
- Build/Sources/TypeScript/install/module/upgrade/upgrade-docs.ts+3 −2
- Build/Sources/TypeScript/install/installer.ts+3 −2
- typo3/sysext/adminpanel/Resources/Public/Css/adminpanel.css+1 −1
- typo3/sysext/backend/Classes/Controller/EditDocumentController.php+2 −3
- typo3/sysext/backend/Classes/Form/Container/InlineRecordContainer.php+2 −3
- typo3/sysext/backend/Classes/Form/Element/BackendLayoutWizardElement.php+53 −65
- typo3/sysext/backend/Classes/Form/Element/SelectMultipleSideBySideElement.php+1 −1
- typo3/sysext/backend/Classes/Tree/View/AbstractTreeView.php+11 −1
- typo3/sysext/backend/Classes/Tree/View/ElementBrowserPageTreeView.php+17 −3
- typo3/sysext/backend/Classes/Tree/View/PagePositionMap.php+5 −5
- typo3/sysext/backend/Classes/View/ArrayBrowser.php+13 −1
- typo3/sysext/backend/Resources/Private/Layouts/Login.html6+3 −3
- typo3/sysext/backend/Resources/Private/Partials/Login/LoginNews.html+3 −2
- typo3/sysext/backend/Resources/Private/Templates/Form/ImageManipulationElement.html+2 −1
- typo3/sysext/backend/Resources/Private/Templates/Form/ImageManipulationWizard.html+3 −3
- typo3/sysext/backend/Resources/Public/Css/backend.css+2 −2
- typo3/sysext/backend/Resources/Public/JavaScript/debug-console.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine-review.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/grid-editor.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/localization.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/notification.js+4 −5
- typo3/sysext/backend/Tests/JavaScript/notification-test.js+1 −1
- typo3/sysext/backend/Tests/Unit/LoginProvider/LoginProviderResolverTest.php+5 −5
- typo3/sysext/beuser/Classes/ViewHelpers/PermissionsViewHelper.php+13 −3
- typo3/sysext/beuser/Resources/Private/Partials/Compare/Information.html+8 −8
- typo3/sysext/core/Classes/Messaging/Renderer/BootstrapRenderer.php+12 −3
- typo3/sysext/core/Classes/Type/ContextualFeedbackSeverity.php+5 −5
- typo3/sysext/core/Classes/TypoScript/ExtendedTemplateService.php+12 −1
- typo3/sysext/core/Tests/Unit/Imaging/IconRegistryTest.php+3 −3
- typo3/sysext/core/Tests/Unit/Messaging/Renderer/BootstrapRendererTest.php+24 −0
- typo3/sysext/extensionmanager/Classes/ViewHelpers/DownloadExtensionViewHelper.php+9 −1
- typo3/sysext/extensionmanager/Resources/Private/Partials/List/UploadForm.html+1 −1
- typo3/sysext/extensionmanager/Resources/Private/Templates/List/Distributions.html+2 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Be/InfoboxViewHelper.php2+10 −24
- typo3/sysext/fluid/Classes/ViewHelpers/FlashMessagesViewHelper.php+6 −3
- typo3/sysext/form/Resources/Private/Backend/Partials/FormEditor/Modals/ValidationErrors.html+1 −1
- typo3/sysext/form/Resources/Public/Css/form.css+12 −1
- typo3/sysext/install/Resources/Private/Partials/Upgrade/UpgradeDocs/PanelItem.html+2 −2
- typo3/sysext/install/Resources/Private/Templates/Installer/ShowDatabaseData.html+2 −2
- typo3/sysext/install/Resources/Private/Templates/Login/ShowLogin.html+2 −2
- typo3/sysext/install/Resources/Public/JavaScript/module/upgrade/upgrade-docs.js+1 −1
- typo3/sysext/install/Resources/Public/JavaScript/installer.js+1 −1
- typo3/sysext/lowlevel/Classes/Database/QueryGenerator.php+7 −7
- typo3/sysext/lowlevel/Tests/Functional/Database/QueryGeneratorTest.php+13 −0
- typo3/sysext/tstemplate/Resources/Private/Partials/ObjectBrowserTree.html+2 −2
Review log 72110
Show 5385 earlier messages
-
Andreas Kienast uploaded patch set 1 07/05/22, 19:39
-
core-ci voted on patch set 1 V -1 07/05/22, 19:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28680
-
Andreas Kienast uploaded patch set 2 07/05/22, 20:00
-
core-ci voted on patch set 2 V -1 07/05/22, 20:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28681
-
Benni Mack commented on patch set 2 07/05/22, 20:30
This is great! Thank you! -
Andreas Kienast uploaded patch set 3 07/06/22, 05:59
-
core-ci voted on patch set 3 V -1 07/06/22, 06:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28688
-
Andreas Kienast uploaded patch set 4 07/08/22, 07:03
-
core-ci voted on patch set 4 V -1 07/08/22, 07:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28739
-
Andreas Kienast uploaded patch set 5 07/08/22, 08:16
-
Andreas Kienast uploaded patch set 6 07/08/22, 08:18
-
core-ci voted on patch set 5 V -1 07/08/22, 08:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28743
-
core-ci voted on patch set 6 V -1 07/08/22, 08:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28744
-
Andreas Kienast uploaded patch set 7 07/08/22, 08:39
-
core-ci voted on patch set 7 V -1 07/08/22, 08:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28745
-
Andreas Kienast uploaded patch set 8 07/08/22, 09:58
-
core-ci voted on patch set 8 V -1 07/08/22, 10:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28749
-
Andreas Kienast uploaded patch set 9 07/08/22, 10:48
-
core-ci voted on patch set 9 V -1 07/08/22, 10:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28753
-
Andreas Kienast uploaded patch set 10 07/08/22, 13:08
-
core-ci voted on patch set 10 V +1 07/08/22, 13:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28755
-
Andreas Kienast uploaded patch set 11 07/08/22, 14:30
-
core-ci voted on patch set 11 V +1 07/08/22, 14:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28761
-
Andreas Kienast uploaded patch set 12 07/08/22, 19:21
-
Andreas Kienast commented on patch set 12 07/08/22, 19:22
-
core-ci voted on patch set 12 V -1 07/08/22, 19:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28770
-
core-ci voted on patch set 12 V +1 07/08/22, 19:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28770
-
Andreas Kienast wrote 07/08/22, 19:55
Topic set to icons -
Andreas Kienast uploaded patch set 13 07/09/22, 05:13
-
core-ci voted on patch set 13 V +1 07/09/22, 05:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28797
-
Andreas Kienast uploaded patch set 14 07/09/22, 13:31
-
core-ci voted on patch set 14 V +1 07/09/22, 13:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28813
-
Nikita Hovratov voted on patch set 14 CR +1 07/10/22, 15:34
-
Nikita Hovratov commented on patch set 14 CR 0 07/10/22, 20:25
The Build/Sources/Sass/typo3/_element_tree.scss still uses Font Awesome. This is the one for the configuration module._icons.scss:37suggestion: display: flex; justify-content: center; align-items: center; and kick: line-height: 2rem; vertical-align: middle; // doesn't seem to have an effect whatsoever. text-align: center; -
Andreas Kienast commented on patch set 14 CR -1 07/11/22, 06:05
_icons.scss:37ReplyOh boy, I didn't check for direct usages of the unicode sequences, great catch! I'll check your suggestions once I removed the remaining icons. -
Andreas Kienast uploaded patch set 15 07/11/22, 06:39
-
Andreas Kienast voted on patch set 15 CR -2 07/11/22, 06:40
-
core-ci voted on patch set 15 V +1 07/11/22, 06:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28862
-
Andreas Kienast uploaded patch set 16 07/11/22, 08:39
-
Andreas Kienast voted on patch set 16 CR 0 07/11/22, 08:39
-
core-ci voted on patch set 16 V -1 07/11/22, 08:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28870
-
Andreas Kienast uploaded patch set 17 07/11/22, 09:14
-
Andreas Kienast commented on patch set 17 07/11/22, 09:15
_icons.scss:37ReplyWorks wonderful, thanks a lot! -
core-ci voted on patch set 17 V +1 07/11/22, 09:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28875
-
Andreas Kienast commented on patch set 17 CR -2 07/11/22, 11:14
Waiting for update of @typo3/icons incorporating https://github.com/TYPO3/TYPO3.Icons/pull/320. -
Andreas Kienast uploaded patch set 18 07/12/22, 06:39
-
core-ci voted on patch set 18 V +1 07/12/22, 06:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28931
-
Benjamin Kott uploaded patch set 19 07/12/22, 12:09
-
core-ci voted on patch set 19 V -1 07/12/22, 12:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28970
-
Andreas Kienast uploaded patch set 20 07/12/22, 13:07
-
Andreas Kienast voted on patch set 20 CR 0 07/12/22, 13:08
-
core-ci voted on patch set 20 V -1 07/12/22, 13:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28976
-
Andreas Kienast uploaded patch set 21 07/12/22, 13:52
-
core-ci voted on patch set 21 V +1 07/12/22, 14:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28980
-
Andreas Kienast uploaded patch set 22 07/12/22, 16:57
-
core-ci voted on patch set 22 V +1 07/12/22, 17:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28997
-
Andreas Kienast uploaded patch set 23 07/13/22, 19:41
-
core-ci voted on patch set 23 V +1 07/13/22, 19:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29097
-
Andreas Kienast uploaded patch set 24 07/15/22, 05:33
-
core-ci voted on patch set 24 V +1 07/15/22, 05:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29183
-
Frank Nägler commented on patch set 24 CR -1 07/15/22, 09:04
InfoboxViewHelper.php:110Use ContextualFeedbackSeverity here -
Andreas Kienast uploaded patch set 25 07/15/22, 09:13
-
Andreas Kienast commented on patch set 25 07/15/22, 09:15
InfoboxViewHelper.php:110ReplyDone -
core-ci voted on patch set 25 V -1 07/15/22, 09:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29193
-
core-ci voted on patch set 25 V +1 07/15/22, 09:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29193
-
Benni Mack voted on patch set 25 CR +1 07/15/22, 09:35
-
Andreas Kienast commented on patch set 25 CR -2 07/15/22, 12:30
A pre-cursor patch regarding icons in login providers will follow. -
Andreas Kienast uploaded patch set 26 07/16/22, 14:09
-
Andreas Kienast voted on patch set 26 CR 0 07/16/22, 14:10
-
core-ci voted on patch set 26 V -1 07/16/22, 14:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29285
-
Andreas Kienast uploaded patch set 27 07/16/22, 14:28
-
core-ci voted on patch set 27 V +1 07/16/22, 14:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29286
-
Nikita Hovratov uploaded patch set 28 07/16/22, 20:31
-
Nikita Hovratov commented on patch set 28 07/16/22, 20:33
^Replaced the element tree expand icons to look (almost) the same as before. -
core-ci voted on patch set 28 V +1 07/16/22, 20:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29301
-
Nikita Hovratov uploaded patch set 29 07/16/22, 20:51
-
core-ci voted on patch set 29 V +1 07/16/22, 21:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29304
-
Anja Leichsenring voted on patch set 29 V +1 CR +1 07/18/22, 13:19
-
Nikita Hovratov uploaded patch set 30 07/19/22, 07:53
-
Nikita Hovratov commented on patch set 30 07/19/22, 07:55
Here are some leftovers in scss that I found: Build/Sources/Sass/typo3/_icons.scss:15: &.fa { Build/Sources/Sass/typo3/_element_cropper.scss:87: &:not(.active) .fa { Build/Sources/Sass/typo3/_main_content.scss:134: .fa { -
Nikita Hovratov commented on patch set 30 07/19/22, 07:58
And in Login: typo3/sysext/backend/Resources/Private/Layouts/Login.html:62: data-loading-text="<i class='fa fa-circle-o-notch fa-spin'></i> {f:translate(key: 'LLL:EXT:backend/Resources/Private/Language/locallang.xlf:login.process')}" typo3/sysext/backend/Resources/Private/Layouts/Login.html:87: <i class="fa fa-fw {provider.icon-class}"></i> -
core-ci voted on patch set 30 V +1 07/19/22, 08:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29350
-
Andreas Kienast commented on patch set 30 07/19/22, 09:15
Login.html:169IIRC there's action-extrrnal or alike which fits better IMO -
Nikita Hovratov commented on patch set 30 07/19/22, 11:33
Login.html:169Replyah ok, go ahead and replace it -
Andreas Kienast commented on patch set 30 07/19/22, 19:12
Reply
Build/Sources/Sass/typo3/_icons.scss:15: &.fa { this is still required for now as some checkbox buttons are hacked and need more love on a broader level.
-
Andreas Kienast uploaded patch set 31 07/19/22, 19:13
-
core-ci voted on patch set 31 V -1 07/19/22, 19:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29366
-
Andreas Kienast uploaded patch set 32 07/19/22, 19:22
-
core-ci voted on patch set 32 V +1 07/19/22, 19:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29367
-
Andreas Kienast commented on patch set 32 CR -2 07/20/22, 19:35
-
Andreas Kienast uploaded patch set 33 07/22/22, 11:53
-
Andreas Kienast commented on patch set 33 CR 0 07/22/22, 11:53
The remaining `.fa` definition in Build/Sources/Sass/typo3/_icons.scss will fall with the removal of FontAwesome. -
core-ci voted on patch set 33 V +1 07/22/22, 12:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29426
-
Nikita Hovratov commented on patch set 33 07/22/22, 19:58
Login.html:87Did we deprecate icon-class? I can only find an Important.rst stating iconIdentifier is allowed now. This will break, when we remove FontAwesome from the backend, or what is the plan here? -
Andreas Kienast commented on patch set 33 07/22/22, 21:10
Login.html:87ReplyYes, this will be gone with FontAwesome. -
Nikita Hovratov commented on patch set 33 07/23/22, 16:01
Login.html:87ReplyAckLogin.html:169ReplyDone -
Nikita Hovratov uploaded patch set 34 07/23/22, 16:57
-
Nikita Hovratov voted on patch set 34 V +1 CR +1 07/23/22, 16:58
-
core-ci voted on patch set 34 V +1 07/23/22, 17:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29455
-
Andreas Kienast uploaded patch set 35 07/27/22, 07:01
-
core-ci voted on patch set 35 V +1 07/27/22, 07:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29605
-
Nikita Hovratov commented on patch set 35 V -1 07/27/22, 07:20
We need to re-add the tree handle icons for the new object browser again. -
Nikita Hovratov uploaded patch set 36 07/27/22, 07:30
-
Andreas Kienast commented on patch set 36 07/27/22, 07:36
Thanks Nikita! -
core-ci voted on patch set 36 V +1 07/27/22, 07:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29606
-
Nikita Hovratov voted on patch set 36 V +1 CR +1 07/27/22, 07:46
-
Benni Mack voted on patch set 36 V +2 CR +2 07/27/22, 07:50
-
Benni Mack merged patch set 37 07/27/22, 07:50
-
Benjamin Franzke commented on patch set 37 08/11/22, 13:02
Small additional note: As far as I know and see things, there is an additional left-over: The entire "icon-unify" class behaviour (scaling icons to 0.86) was only needed for font-awesome. So I think we could drop that as well. -
Andreas Kienast commented on patch set 37 08/11/22, 13:06
Reply
Thanks. I wanted to take another look at the remaining icon classes soon, I'll check that one as well.