Review main Merged

75043[TASK] Clean up TMENU code

Benni Mack CR +2 V +2 Normal +27 −43 updated 07/07/22, 20:47

Commit message

This change reduces the logic within TMENU in order
to further unify link generation within the menu rendering.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1013

  1. Benni Mack uploaded patch set 1 07/07/22, 08:45

  2. core-ci voted on patch set 1 V -1 07/07/22, 08:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28700

  3. Benni Mack commented on patch set 2 07/07/22, 09:28

    Published edit on patch set 1.
  4. core-ci voted on patch set 2 V -1 07/07/22, 09:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28703

  5. Benni Mack commented on patch set 3 07/07/22, 10:59

    Published edit on patch set 2.
  6. core-ci voted on patch set 3 V +1 07/07/22, 11:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28709

  7. Nikita Hovratov commented on patch set 3 07/07/22, 19:24

    TextMenuContentObject.php:74

    To be 100% strict this is a change in behaviour: https://3v4l.org/6C8W9 All truthy strings will now also disable linking, whereas before it was only possible with "1", 1 or true. Of course this should work like this as in every boolean TypoScript type, but I just wanted to mention this. Probably would have little to no impact.
  8. Benni Mack commented on patch set 3 07/07/22, 19:29

    TextMenuContentObject.php:74 Reply

    yes. exactly. in most cases around TypoScript, we check against a falsy string, and I think this is very convenient, so this is much streamlining and cleaning up.
  9. Nikita Hovratov commented on patch set 3 CR +1 07/07/22, 19:33

    TextMenuContentObject.php:74 Reply

    Done
  10. Nikita Hovratov voted on patch set 3 V +1 07/07/22, 19:36

  11. Oli Bartsch voted on patch set 3 V +1 CR +1 07/07/22, 20:46

  12. Benni Mack voted on patch set 3 V +2 CR +2 07/07/22, 20:47

  13. Benni Mack merged patch set 4 07/07/22, 20:47