Review main Merged

75047[BUGFIX] Add missing msclkid parameter to cacheHash excludedParameters

dsteinborn CR +2 V +2 Easy +1 −1 updated 07/08/22, 21:32

Commit message

"msclkid" is the Click ID parameter of Microsoft / Bing
which should be excluded from cHash generation.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Benni Mack +2
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 810

  1. dsteinborn uploaded patch set 1 07/07/22, 21:50

  2. core-ci voted on patch set 1 V +1 07/07/22, 21:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28734

  3. Simon Schaufelberger voted on patch set 1 V +1 CR +1 07/08/22, 02:04

  4. Benni Mack updated the commit message in patch set 2 07/08/22, 20:33

  5. Benni Mack voted on patch set 2 V +1 CR +1 07/08/22, 20:34

  6. core-ci voted on patch set 2 V +1 07/08/22, 20:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28778

  7. Simon Schaufelberger voted on patch set 2 V +1 CR +1 07/08/22, 20:56

  8. Oliver Klee voted on patch set 2 CR +1 07/08/22, 21:06

  9. Benni Mack voted on patch set 2 V +2 CR +2 07/08/22, 21:32

  10. Benni Mack merged patch set 3 07/08/22, 21:32