Review main Merged

75048[BUGFIX] Use `$validator->setOptions()` in ValidatorResolverService

Nikita Hovratov CR +2 V +2 Easy +7 −3 updated 07/11/22, 14:28

Commit message

With the refactoring in #96998 the validator options are now passed
with the `setOptions` method instead of passing them as constructor
argument.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 812

  1. Nikita Hovratov uploaded patch set 1 07/08/22, 07:20

  2. core-ci voted on patch set 1 V +1 07/08/22, 07:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28740

  3. Stefan Bürk updated the commit message in patch set 2 07/08/22, 21:08

  4. core-ci voted on patch set 2 V +1 07/08/22, 21:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28780

  5. Stefan Bürk voted on patch set 2 V +1 CR +1 07/08/22, 21:16

  6. Nikita Hovratov uploaded patch set 3 07/09/22, 16:43

  7. core-ci voted on patch set 3 V -1 07/09/22, 16:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28821

  8. core-ci voted on patch set 3 V +1 07/09/22, 17:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28821

  9. Oliver Klee voted on patch set 3 CR +1 07/09/22, 17:19

  10. Stefan Bürk voted on patch set 3 V +1 CR +1 07/09/22, 20:07

  11. Benni Mack voted on patch set 3 V +2 CR +2 07/11/22, 14:28

  12. Benni Mack merged patch set 4 07/11/22, 14:28