75051[BUGFIX] Update CSS in `typo3-backend-icon`
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Oli Bartsch +1
-
Verified V +2 Done
- Andreas Kienast +2
- Oli Bartsch +1
- core-ci +1 CI
Issues 1
Files 2
Review log 910
-
Andreas Kienast uploaded patch set 1 07/08/22, 10:46
-
Andreas Kienast commented on patch set 1 07/08/22, 10:46
Can be tested with JavaScript notifications altogether with https://review.typo3.org/c/Packages/TYPO3.CMS/+/75041. -
core-ci voted on patch set 1 V +1 07/08/22, 10:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28752
-
Oliver Hader commented on patch set 1 07/08/22, 19:41
(I'm not a CSS custom variable expert)... Where is the declaration for `--icon-size` coming from? -
Andreas Kienast commented on patch set 1 07/08/22, 19:45
Reply
--icon-size is defined for each host (aka root) node based on the "size" attribute. The variable that's inherited into --icon-size is defined in the component itself (e.g. --icon-size-small), which is a blatant copy from @typo3/icons. -
Andreas Kienast commented on patch set 1 07/08/22, 19:46
Reply
This is done in the helper function "iconSize()", which is called multiple times for the available sizes. -
Andreas Kienast wrote 07/08/22, 19:55
Topic set to icons -
Oli Bartsch voted on patch set 1 V +1 CR +1 07/12/22, 13:07
-
Andreas Kienast voted on patch set 1 V +2 CR +2 07/15/22, 05:33
-
Andreas Kienast merged patch set 2 07/15/22, 05:34