Review 11.5 Merged

75055[TASK] Annotate that methods from InaccessibleFolder never return

Oliver Klee CR +2 V +2 Normal +19 −72 updated 07/07/22, 18:21

Commit message

Methods from InaccessibleFolder should not be called and always
throw an exception when called. Annotate this to help static code
analysis understand this.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 57

  1. Oliver Klee commented on patch set 1 07/07/22, 15:07

    Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/core/Classes/Resource/InaccessibleFolder.php
  2. Oliver Klee uploaded patch set 2 07/07/22, 15:15

  3. Oliver Klee marked it ready for review 07/07/22, 15:15

  4. core-ci voted on patch set 1 V -1 07/07/22, 15:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28716

  5. core-ci voted on patch set 2 V +1 07/07/22, 15:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28717

  6. Stefan Bürk voted on patch set 2 V +2 CR +2 07/07/22, 18:21

  7. Stefan Bürk merged patch set 3 07/07/22, 18:21