Review 11.5 Merged

75073[TASK] Use local TypoScriptFrontendController in ContentObjects

Rafael Kähm CR +2 V +2 Normal +78 −109 updated 07/22/22, 13:37

Commit message

Adapts several content objects to use the local
TypoScriptFrontendController instance of ContentObjectRenderer, to
reduce usage of global objects and to avoid conflicts when different
frontend environments are used, e.g. while indexing with EXT:solr.

This adaption should be safe as the ContentObjectRenderer falls
back to the global TypoScriptFrontendController, which was used in
the content objects until now. If TypoScriptFrontendController is
not available, a ContentRenderingException is thrown.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Markus Friedrich +1
  • Verified V +2 Done
    • Benni Mack +2
    • Markus Friedrich +1
    • core-ci +1 CI

Issues 1

Files 17

Review log 3247

Show 1522 earlier messages
  1. Rafael Kähm uploaded patch set 1 07/08/22, 14:30

  2. core-ci voted on patch set 1 V -1 07/08/22, 14:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28760

  3. Simon Schaufelberger updated the commit message in patch set 2 07/08/22, 15:32

  4. Simon Schaufelberger commented on patch set 2 07/08/22, 15:33

    hä? Whe are there 2 patches with the same target branch? https://review.typo3.org/c/Packages/TYPO3.CMS/+/74682
  5. core-ci voted on patch set 2 V -1 07/08/22, 15:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28763

  6. Nikita Hovratov commented on patch set 2 07/08/22, 15:55

    There was no backport intended for this patch. Besides, only core-merger should backport patches.
  7. Nikita Hovratov abandoned the change 07/08/22, 15:56

    No backport for this patch.
  8. Nikita Hovratov restored the change 07/08/22, 16:33

  9. Rafael Kähm commented on patch set 2 07/08/22, 16:34

    I'll prepare it for Benni.
  10. Rafael Kähm uploaded patch set 3 07/08/22, 16:34

  11. core-ci voted on patch set 3 V -1 07/08/22, 16:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28768

  12. Rafael Kähm uploaded patch set 4 07/08/22, 16:52

  13. Rafael Kähm commented on patch set 4 07/08/22, 16:56

    Reply

    Done
    So i fixed currently the CI issues. I'll proceed with all hints from comments of main patch https://review.typo3.org/c/Packages/TYPO3.CMS/+/74681 next week.
  14. core-ci voted on patch set 4 V +1 07/08/22, 16:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28769

  15. Nikita Hovratov commented on patch set 4 07/08/22, 19:38

    Commit message header duplicated somehow. I'd prefer the second one like in the main patch.
  16. Stefan Bürk updated the commit message in patch set 5 07/08/22, 19:50

  17. core-ci voted on patch set 5 V +1 07/08/22, 19:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28774

  18. Benni Mack commented on patch set 5 07/08/22, 21:35

    Reply

    Done
  19. Rafael Kähm uploaded patch set 6 07/15/22, 06:58

  20. core-ci voted on patch set 6 V -1 07/15/22, 07:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29185

  21. Rafael Kähm uploaded patch set 7 07/15/22, 10:06

  22. core-ci voted on patch set 7 V -1 07/15/22, 10:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29200

  1. Rafael Kähm uploaded patch set 8 07/15/22, 10:33

  2. core-ci voted on patch set 8 V +1 07/15/22, 10:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29201

  3. Rafael Kähm uploaded patch set 9 07/15/22, 11:57

  4. Rafael Kähm commented on patch set 9 V +1 CR +1 07/15/22, 12:02

    Hey folks, i equalized the changes from main to 11.5 as similar as possible. Please proceed with review.
  5. core-ci voted on patch set 9 V +1 07/15/22, 12:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29207

  6. Rafael Kähm uploaded patch set 10 07/15/22, 12:25

  7. core-ci voted on patch set 10 V +1 07/15/22, 12:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29209

  8. Rafael Kähm uploaded patch set 11 07/15/22, 12:40

  9. core-ci voted on patch set 11 V +1 07/15/22, 12:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29210

  10. Rafael Kähm commented on patch set 11 V +1 CR +1 07/15/22, 14:11

    Now LGTM
  11. Rafael Kähm uploaded patch set 12 07/15/22, 14:19

  12. Nikita Hovratov commented on patch set 12 07/15/22, 14:39

    Reply

    Hey Rafael, FYI: we have a rule that voting for own patches is not allowed.
  13. core-ci voted on patch set 12 V +1 07/15/22, 14:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29221

  14. Rafael Kähm uploaded patch set 13 07/16/22, 08:30

  15. core-ci voted on patch set 13 V +1 07/16/22, 08:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29263

  16. Rafael Kähm uploaded patch set 14 07/18/22, 07:20

  17. core-ci voted on patch set 14 V -1 07/18/22, 07:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29329

  18. Benni Mack uploaded patch set 15 07/18/22, 20:42

  19. core-ci voted on patch set 15 V +1 07/18/22, 20:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29338

  20. Benni Mack voted on patch set 15 CR +1 07/18/22, 20:59

  21. Simon Schaufelberger wrote 07/18/22, 22:33

    Removed cc Simon Schaufelberger.
  22. Markus Friedrich voted on patch set 15 CR +1 07/22/22, 08:49

  23. Markus Friedrich voted on patch set 15 V +1 07/22/22, 12:02

  24. Benni Mack voted on patch set 15 V +2 CR +2 07/22/22, 13:37

  25. Benni Mack merged patch set 16 07/22/22, 13:37