75073[TASK] Use local TypoScriptFrontendController in ContentObjects
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Markus Friedrich +1
-
Verified V +2 Done
- Benni Mack +2
- Markus Friedrich +1
- core-ci +1 CI
Issues 1
Files 17
- typo3/sysext/frontend/Classes/ContentObject/Menu/AbstractMenuContentObject.php+12 −8
- typo3/sysext/frontend/Classes/ContentObject/Menu/TextMenuContentObject.php+3 −2
- typo3/sysext/frontend/Classes/ContentObject/ContentContentObject.php+2 −13
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectArrayInternalContentObject.php+5 −12
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php+1 −1
- typo3/sysext/frontend/Classes/ContentObject/EditPanelContentObject.php+1 −1
- typo3/sysext/frontend/Classes/ContentObject/FilesContentObject.php+3 −14
- typo3/sysext/frontend/Classes/ContentObject/HierarchicalMenuContentObject.php+9 −6
- typo3/sysext/frontend/Classes/ContentObject/ImageContentObject.php+4 −10
- typo3/sysext/frontend/Classes/ContentObject/ImageResourceContentObject.php+8 −8
- typo3/sysext/frontend/Classes/ContentObject/LoadRegisterContentObject.php+3 −2
- typo3/sysext/frontend/Classes/ContentObject/RecordsContentObject.php+13 −20
- typo3/sysext/frontend/Classes/ContentObject/RestoreRegisterContentObject.php+2 −1
- typo3/sysext/frontend/Classes/ContentObject/UserInternalContentObject.php+0 −8
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php+6 −0
- typo3/sysext/frontend/Tests/Functional/ContentObject/FilesContentObjectTest.php+2 −3
- typo3/sysext/frontend/Tests/Unit/ContentObject/Menu/AbstractMenuContentObjectTest.php+4 −0
Review log 3247
Show 1522 earlier messages
-
Rafael Kähm uploaded patch set 1 07/08/22, 14:30
-
core-ci voted on patch set 1 V -1 07/08/22, 14:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28760
-
Simon Schaufelberger updated the commit message in patch set 2 07/08/22, 15:32
-
Simon Schaufelberger commented on patch set 2 07/08/22, 15:33
hä? Whe are there 2 patches with the same target branch? https://review.typo3.org/c/Packages/TYPO3.CMS/+/74682 -
core-ci voted on patch set 2 V -1 07/08/22, 15:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28763
-
Nikita Hovratov commented on patch set 2 07/08/22, 15:55
There was no backport intended for this patch. Besides, only core-merger should backport patches. -
Nikita Hovratov abandoned the change 07/08/22, 15:56
No backport for this patch. -
Nikita Hovratov restored the change 07/08/22, 16:33
-
Rafael Kähm commented on patch set 2 07/08/22, 16:34
I'll prepare it for Benni. -
Rafael Kähm uploaded patch set 3 07/08/22, 16:34
-
core-ci voted on patch set 3 V -1 07/08/22, 16:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28768
-
Rafael Kähm uploaded patch set 4 07/08/22, 16:52
-
Rafael Kähm commented on patch set 4 07/08/22, 16:56
Reply
DoneSo i fixed currently the CI issues. I'll proceed with all hints from comments of main patch https://review.typo3.org/c/Packages/TYPO3.CMS/+/74681 next week. -
core-ci voted on patch set 4 V +1 07/08/22, 16:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28769
-
Nikita Hovratov commented on patch set 4 07/08/22, 19:38
Commit message header duplicated somehow. I'd prefer the second one like in the main patch. -
Stefan Bürk updated the commit message in patch set 5 07/08/22, 19:50
-
core-ci voted on patch set 5 V +1 07/08/22, 19:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28774
-
Benni Mack commented on patch set 5 07/08/22, 21:35
Reply
Done -
Rafael Kähm uploaded patch set 6 07/15/22, 06:58
-
core-ci voted on patch set 6 V -1 07/15/22, 07:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29185
-
Rafael Kähm uploaded patch set 7 07/15/22, 10:06
-
core-ci voted on patch set 7 V -1 07/15/22, 10:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29200
-
Rafael Kähm uploaded patch set 8 07/15/22, 10:33
-
core-ci voted on patch set 8 V +1 07/15/22, 10:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29201
-
Rafael Kähm uploaded patch set 9 07/15/22, 11:57
-
Rafael Kähm commented on patch set 9 V +1 CR +1 07/15/22, 12:02
Hey folks, i equalized the changes from main to 11.5 as similar as possible. Please proceed with review. -
core-ci voted on patch set 9 V +1 07/15/22, 12:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29207
-
Rafael Kähm uploaded patch set 10 07/15/22, 12:25
-
core-ci voted on patch set 10 V +1 07/15/22, 12:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29209
-
Rafael Kähm uploaded patch set 11 07/15/22, 12:40
-
core-ci voted on patch set 11 V +1 07/15/22, 12:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29210
-
Rafael Kähm commented on patch set 11 V +1 CR +1 07/15/22, 14:11
Now LGTM -
Rafael Kähm uploaded patch set 12 07/15/22, 14:19
-
Nikita Hovratov commented on patch set 12 07/15/22, 14:39
Reply
Hey Rafael, FYI: we have a rule that voting for own patches is not allowed. -
core-ci voted on patch set 12 V +1 07/15/22, 14:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29221
-
Rafael Kähm uploaded patch set 13 07/16/22, 08:30
-
core-ci voted on patch set 13 V +1 07/16/22, 08:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29263
-
Rafael Kähm uploaded patch set 14 07/18/22, 07:20
-
core-ci voted on patch set 14 V -1 07/18/22, 07:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29329
-
Benni Mack uploaded patch set 15 07/18/22, 20:42
-
core-ci voted on patch set 15 V +1 07/18/22, 20:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29338
-
Benni Mack voted on patch set 15 CR +1 07/18/22, 20:59
-
Simon Schaufelberger wrote 07/18/22, 22:33
Removed cc Simon Schaufelberger. -
Markus Friedrich voted on patch set 15 CR +1 07/22/22, 08:49
-
Markus Friedrich voted on patch set 15 V +1 07/22/22, 12:02
-
Benni Mack voted on patch set 15 V +2 CR +2 07/22/22, 13:37
-
Benni Mack merged patch set 16 07/22/22, 13:37