Review main Merged

75079[BUGFIX] Always call GU::intExplode with a string in EXT:frontend

Oliver Klee CR +2 V +2 Easy +7 −6 updated 07/10/22, 14:00

Commit message

This helps avoid breakage when GeneralUtility will switch to
strict mode.

This change also prevents a bunch of possible invalid
array access warnings.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 2

Files 4

Review log 79

  1. Oliver Klee uploaded patch set 1 07/09/22, 10:00

  2. Oliver Klee commented on patch set 1 07/09/22, 10:02

    How to verify: Check that the tests in https://review.typo3.org/c/Packages/TYPO3.CMS/+/74572 are green (that has these changes and marks the GU class as strict).
  3. core-ci voted on patch set 1 V +1 07/09/22, 10:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28800

  4. Stefan Bürk voted on patch set 1 V +1 CR +1 07/09/22, 20:27

  5. Nikita Hovratov updated the commit message in patch set 2 07/09/22, 21:23

  6. Nikita Hovratov commented on patch set 2 V +1 CR +1 07/09/22, 21:23

    Relates -> Related
  7. core-ci voted on patch set 2 V +1 07/09/22, 21:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28837

  8. Stefan Bürk voted on patch set 2 V +2 CR +2 07/10/22, 14:00

  9. Stefan Bürk merged patch set 3 07/10/22, 14:00