Review main Merged

75080[BUGFIX] Always call GU::intExplode with a string

Oliver Klee CR +2 V +2 Easy +23 −19 updated 07/09/22, 21:30

Commit message

This helps avoid breakage when GeneralUtility will switch to
strict mode.

This change also prevents a bunch of possible invalid
array access warnings.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 2

Files 9

Review log 1013

  1. Oliver Klee uploaded patch set 1 07/09/22, 10:32

  2. Oliver Klee commented on patch set 1 07/09/22, 10:32

    How to verify: Check that the tests in https://review.typo3.org/c/Packages/TYPO3.CMS/+/74572 are green (that has these changes and marks the GU class as strict).
  3. core-ci voted on patch set 1 V -1 07/09/22, 10:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28803

  4. Oliver Klee commented on patch set 1 CR -1 07/09/22, 10:40

    On it.
  5. Oliver Klee uploaded patch set 2 07/09/22, 10:43

  6. core-ci voted on patch set 2 V +1 07/09/22, 10:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28804

  7. Stefan Bürk voted on patch set 2 V +1 CR +1 07/09/22, 20:26

  8. Nikita Hovratov updated the commit message in patch set 3 07/09/22, 21:13

  9. Nikita Hovratov commented on patch set 3 V +1 CR +1 07/09/22, 21:15

    Changed "Relates" to "Related".
  10. core-ci voted on patch set 3 V +1 07/09/22, 21:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28836

  11. Oliver Klee commented on patch set 3 07/09/22, 21:26

    Thanks, Nikita!
  12. Stefan Bürk voted on patch set 3 V +2 CR +2 07/09/22, 21:30

  13. Stefan Bürk merged patch set 4 07/09/22, 21:30