Review main Merged

75081[DOCS] Improve changelog for #97454 - new LinkHandler events

Lina Wolf CR +2 V +2 Easy +31 −6 updated 07/10/22, 07:44

Commit message

- mention the methods of the removed hook to make it easier
  for developers to search for them.
- add missing description of the ModifyAllowedItemsEvent

Review

  • Code review CR +2 Done
    • Lina Wolf +2
    • Stefan Bürk +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Lina Wolf +2
    • Stefan Bürk +1
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 1723

  1. Lina Wolf uploaded patch set 1 07/09/22, 11:20

  2. Lina Wolf updated the commit message in patch set 2 07/09/22, 11:21

  3. Lina Wolf uploaded patch set 3 07/09/22, 11:25

  4. core-ci voted on patch set 1 V +1 07/09/22, 11:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28807

  5. core-ci voted on patch set 2 V +1 07/09/22, 11:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28808

  6. core-ci voted on patch set 3 V +1 07/09/22, 11:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28809

  7. Stefan Bürk commented on patch set 3 07/09/22, 12:14

    Feature-97454-PSR14EventsForLinkBrowserLifecycle.rst:27

    My bad, this is wrong. This allows extensions to add or remove from the list of allowed link types, not the link handlers itself ...
  8. Stefan Bürk uploaded patch set 4 07/09/22, 20:22

  9. Stefan Bürk commented on patch set 4 07/09/22, 20:22

    Feature-97454-PSR14EventsForLinkBrowserLifecycle.rst:27 Reply

    Done
  10. Stefan Bürk voted on patch set 4 V +1 CR +1 07/09/22, 20:23

  11. Nikita Hovratov commented on patch set 4 07/09/22, 20:29

    Breaking-97454-RemoveLinkBrowserHooks.rst:15

    its
  12. core-ci voted on patch set 4 V +1 07/09/22, 20:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28828

  13. Nikita Hovratov commented on patch set 4 CR -1 07/09/22, 20:30

    on it
  14. Nikita Hovratov uploaded patch set 5 07/09/22, 20:51

  15. Nikita Hovratov voted on patch set 5 V +1 CR +1 07/09/22, 20:51

  16. Nikita Hovratov commented on patch set 5 07/09/22, 20:51

    Breaking-97454-RemoveLinkBrowserHooks.rst:15 Reply

    Done
  17. Nikita Hovratov updated the commit message in patch set 6 07/09/22, 20:53

  18. Nikita Hovratov voted on patch set 6 V +1 CR +1 07/09/22, 20:53

  19. core-ci voted on patch set 6 V +1 07/09/22, 21:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28834

  20. core-ci voted on patch set 5 V +1 07/09/22, 21:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28833

  21. Stefan Bürk voted on patch set 6 V +1 CR +1 07/09/22, 21:30

  22. Lina Wolf voted on patch set 6 V +2 CR +2 07/10/22, 07:43

  23. Lina Wolf merged patch set 7 07/10/22, 07:44