Review main Merged

75085[BUGFIX] Use correct variable name for confirmation of FormEngine reload

Andreas Kienast CR +2 V +2 Easy +3 −3 updated 07/09/22, 21:10

Commit message

The confirmation dialog when FormEngine requests an update never came
up in FlexForms as the array key used in
`TYPO3\CMS\Backend\Form\Behavior\ReloadOnFieldChange->toArray()` didn't
match the key in the `typo3-backend-form-reload` handler in FormEngine
JavaScript, which is solved in this commit.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Stefan Bürk +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Stefan Bürk +1
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 67

  1. Andreas Kienast uploaded patch set 1 07/09/22, 14:25

  2. core-ci voted on patch set 1 V +1 07/09/22, 14:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28817

  3. Andreas Kienast commented on patch set 1 07/09/22, 15:53

    Can be tested with styleguide > displaycond > Flexforms > flex_2 > select_1
  4. Nikita Hovratov voted on patch set 1 V +1 CR +1 07/09/22, 16:50

  5. Stefan Bürk voted on patch set 1 V +1 CR +1 07/09/22, 20:09

  6. Andreas Kienast voted on patch set 1 V +2 CR +2 07/09/22, 21:10

  7. Andreas Kienast merged patch set 2 07/09/22, 21:10