Review main Merged

75086[BUGFIX] Set current time as default in flatpickr

Andreas Kienast CR +2 V +2 Easy +4 −1 updated 07/12/22, 10:21

Commit message

flatpickr always defaults to 12:00 if no other value is given, being
quite inconvenient. The options `defaultHour` and `defaultMinute` are
now provided to set the current time when opening flatpickr on an empty
input field.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 56

  1. Andreas Kienast uploaded patch set 1 07/09/22, 14:45

  2. core-ci voted on patch set 1 V +1 07/09/22, 14:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28818

  3. Nikita Hovratov voted on patch set 1 V +1 CR +1 07/10/22, 14:18

  4. Stefan Bürk voted on patch set 1 CR +1 07/11/22, 14:27

  5. Oli Bartsch voted on patch set 1 V +2 CR +2 07/12/22, 10:21

  6. Oli Bartsch merged patch set 2 07/12/22, 10:21