75091[BUGFIX] Cast `$chars` argument of `fixed_lgd_cs()` to int
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Oli Bartsch +1
- Oliver Klee +1
-
Verified V +2 Done
- Stefan Bürk +2
- Oli Bartsch +1
- core-ci +1 CI
Issues 2
Files 18
- typo3/sysext/backend/Classes/Clipboard/Clipboard.php+3 −3
- typo3/sysext/backend/Classes/ContextMenu/ItemProviders/RecordProvider.php+3 −3
- typo3/sysext/backend/Classes/Controller/EditDocumentController.php+1 −1
- typo3/sysext/backend/Classes/Form/Element/GroupElement.php+1 −1
- typo3/sysext/backend/Classes/Form/FieldWizard/RecordsOverview.php+1 −1
- typo3/sysext/backend/Classes/Template/Components/MetaInformation.php+1 −1
- typo3/sysext/backend/Classes/Tree/View/AbstractTreeView.php+1 −1
- typo3/sysext/backend/Classes/Tree/View/PagePositionMap.php+1 −1
- typo3/sysext/backend/Classes/Tree/View/PageTreeView.php+1 −1
- typo3/sysext/backend/Classes/Utility/BackendUtility.php3+4 −4
- typo3/sysext/core/Classes/TimeTracker/TimeTracker.php+1 −1
- typo3/sysext/core/Classes/Utility/GeneralUtility.php3+3 −1
- typo3/sysext/filelist/Classes/ContextMenu/ItemProviders/FileProvider.php+1 −1
- typo3/sysext/filelist/Classes/FileList.php+1 −1
- typo3/sysext/indexed_search/Classes/Controller/SearchController.php+2 −2
- typo3/sysext/info/Classes/Controller/TranslationStatusController.php+1 −1
- typo3/sysext/tstemplate/Classes/Controller/TemplateAnalyzerController.php+1 −1
- typo3/sysext/workspaces/Classes/Service/GridDataService.php+2 −2
Review log 2228
Show 23 earlier messages
-
Andreas Kienast uploaded patch set 1 07/11/22, 06:26
-
core-ci voted on patch set 1 V +1 07/11/22, 06:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28861
-
Andreas Kienast uploaded patch set 2 07/11/22, 06:40
-
core-ci voted on patch set 2 V +1 07/11/22, 06:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28863
-
Francois Suter commented on patch set 2 V +1 CR -1 07/11/22, 07:14
One small comment on a line which seems leftover from a first attempt at fixing the issue.GeneralUtility.php:195I guess this is a leftover? -
Oliver Klee commented on patch set 3 07/11/22, 07:17
Published edit on patch set 2. -
Oliver Klee commented on patch set 3 CR +1 07/11/22, 07:17
GeneralUtility.php:195ReplyDone -
Oliver Klee updated the commit message in patch set 4 07/11/22, 07:18
-
Oliver Klee voted on patch set 4 CR +1 07/11/22, 07:18
-
Stefan Bürk voted on patch set 4 V +1 CR +1 07/11/22, 07:23
-
core-ci voted on patch set 3 V +1 07/11/22, 07:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28865
-
core-ci voted on patch set 4 V +1 07/11/22, 07:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28866
-
Stefan Bürk commented on patch set 4 07/11/22, 07:45
Should we not add sanity type cast's for second and third argument in `fixed_lgd_cs()` also ? At least until strict argument types are set. $chars has been casted for the if check, but not for the abs() call in there ... -
Stefan Bürk commented on patch set 4 CR -1 07/11/22, 07:59
on it -
Andreas Kienast commented on patch set 4 07/11/22, 08:09
GeneralUtility.php:195ReplyNope, that was intentionally there and I just forgot to un-comment it again. -
Stefan Bürk uploaded patch set 5 07/11/22, 08:10
-
Oliver Klee voted on patch set 5 CR +1 07/11/22, 08:16
-
core-ci voted on patch set 5 V +1 07/11/22, 08:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28867
-
Stefan Bürk voted on patch set 5 V +1 CR +1 07/11/22, 08:28
-
Oli Bartsch uploaded patch set 6 07/11/22, 08:29
-
Oli Bartsch commented on patch set 6 V +1 CR +1 07/11/22, 08:31
Thanks for taking care Andy! -
Oliver Klee voted on patch set 6 CR +1 07/11/22, 08:32
-
core-ci voted on patch set 6 V +1 07/11/22, 08:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28869
-
Stefan Bürk voted on patch set 6 V +2 CR +2 07/11/22, 08:40
-
Stefan Bürk merged patch set 7 07/11/22, 08:41
-
Nikita Hovratov commented on patch set 7 07/11/22, 08:46
BackendUtility.php:1474This can still be a positive integer string. -
Oli Bartsch commented on patch set 7 07/11/22, 08:49
BackendUtility.php:1474Reply -
Stefan Bürk commented on patch set 7 07/11/22, 13:16
BackendUtility.php:1474ReplyDone