75093[!!!][FEATURE] Use LanguageAspect in QuerySettings for Extbase
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Oliver Hader +1
-
Verified V +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Oliver Hader +1
- core-ci +1 CI
Issues 1
Files 14
- Build/phpstan/phpstan-baseline.neon+0 −5
- typo3/sysext/core/Documentation/Changelog/12.0/Breaking-97926-ExtbaseQuerySettingsMethodsRemoved.rstnew+59 −0
- typo3/sysext/core/Documentation/Changelog/12.0/Feature-97926-ConfigureExtbasePersistenceLanguageViaLanguageAspect.rstnew+36 −0
- typo3/sysext/extbase/Classes/Persistence/Generic/Mapper/DataMapper.php+13 −5
- typo3/sysext/extbase/Classes/Persistence/Generic/Storage/Typo3DbBackend.php7+22 −10
- typo3/sysext/extbase/Classes/Persistence/Generic/Storage/Typo3DbQueryParser.php+11 −10
- typo3/sysext/extbase/Classes/Persistence/Generic/Backend.php+11 −1
- typo3/sysext/extbase/Classes/Persistence/Generic/QuerySettingsInterface.php5+13 −22
- typo3/sysext/extbase/Classes/Persistence/Generic/Typo3QuerySettings.php4+55 −48
- typo3/sysext/extbase/Tests/Functional/Persistence/QueryLocalizedDataTest.php11+35 −90
- typo3/sysext/extbase/Tests/Functional/Persistence/TranslationTest.php13+22 −66
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/Storage/Typo3DbBackendTest.php+2 −0
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/Storage/Typo3DbQueryParserTest.php+7 −9
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/Typo3QuerySettingsTest.php4+3 −2
Review log 3957
Show 2032 earlier messages
-
Benni Mack uploaded patch set 1 07/11/22, 08:17
-
core-ci voted on patch set 1 V -1 07/11/22, 08:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28868
-
Benni Mack uploaded patch set 2 07/11/22, 11:56
-
core-ci voted on patch set 2 V -1 07/11/22, 12:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28882
-
Benni Mack uploaded patch set 3 07/12/22, 19:21
-
core-ci voted on patch set 3 V -1 07/12/22, 19:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29011
-
Benni Mack uploaded patch set 4 07/13/22, 13:45
-
core-ci voted on patch set 4 V -1 07/13/22, 13:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29063
-
Benni Mack uploaded patch set 5 07/13/22, 14:10
-
core-ci voted on patch set 5 V -1 07/13/22, 14:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29067
-
Benni Mack uploaded patch set 6 07/13/22, 14:32
-
core-ci voted on patch set 6 V -1 07/13/22, 14:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29069
-
Benni Mack uploaded patch set 7 07/13/22, 14:44
-
core-ci voted on patch set 7 V +1 07/13/22, 14:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29071
-
Benni Mack uploaded patch set 8 07/13/22, 15:37
-
core-ci voted on patch set 8 V +1 07/13/22, 15:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29075
-
Markus Klein commented on patch set 9 07/13/22, 18:01
Published edit on patch set 8. -
Markus Klein commented on patch set 10 07/13/22, 18:03
Published edit on patch set 9. -
core-ci voted on patch set 10 V +1 07/13/22, 18:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29083
-
core-ci voted on patch set 9 V +1 07/13/22, 18:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29082
-
Markus Klein commented on patch set 11 07/13/22, 18:22
Published edit on patch set 10. -
core-ci voted on patch set 11 V +1 07/13/22, 18:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29085
-
Markus Klein commented on patch set 11 07/13/22, 18:33
Typo3DbBackend.php:522I think this should rather be `$fetchLocalizedRecord`, right? (we are not fetching the language record anywhere here)Typo3QuerySettings.php:197Shouldn't this retain the other options of the current aspect? -
Markus Klein commented on patch set 11 07/13/22, 18:42
QueryLocalizedDataTest.php:251until now we tested with OVERLAYS_ON here in the fake TSFE language aspect. Is this change intended?QueryLocalizedDataTest.php:326shouldn't this be _OFF?QueryLocalizedDataTest.php:347shouldn't this be _OFF?TranslationTest.php:107overlay_OFF is missing hereTranslationTest.php:200shouldn't this be _OFF?TranslationTest.php:320_OFF missingTranslationTest.php:345here tooTranslationTest.php:459here too and all below.. -
Benni Mack commented on patch set 11 07/13/22, 19:20
thanks for the review, Markus!QueryLocalizedDataTest.php:251Replytbh, OVERLAYS_ON should be removed in the future. This means that records without l10n_parent are never shown, Even though the whole concepts of overlays stinks, this is for sure the worst option of the now available 4 options.TranslationTest.php:200Replycomment says "This tests shows overlays in action" :) OVERLAYS_FF just fetches records without fallback, as it only queries sys_language_uid=2 -
Benni Mack uploaded patch set 12 07/14/22, 10:46
-
core-ci voted on patch set 12 V +1 07/14/22, 10:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29133
-
Markus Klein commented on patch set 12 07/14/22, 11:37
Typo3DbBackend.php:522ReplyDoneTypo3QuerySettings.php:197ReplyDoneQueryLocalizedDataTest.php:251ReplyDoneQueryLocalizedDataTest.php:326should be _OFFQueryLocalizedDataTest.php:347should be _OFFTranslationTest.php:107ReplyDoneTranslationTest.php:200ReplyDoneTranslationTest.php:320ReplyDoneTranslationTest.php:345ReplyDoneTranslationTest.php:375this must be _ONTranslationTest.php:459ReplyDone -
Markus Klein commented on patch set 13 07/14/22, 11:37
Published edit on patch set 12. -
Markus Klein commented on patch set 14 07/14/22, 11:40
Published edit on patch set 13. -
Markus Klein commented on patch set 14 07/14/22, 11:40
QueryLocalizedDataTest.php:326ReplyDoneQueryLocalizedDataTest.php:326ReplyDoneQueryLocalizedDataTest.php:347ReplyDoneQueryLocalizedDataTest.php:347ReplyDoneTranslationTest.php:375ReplyDone -
Markus Klein commented on patch set 15 07/14/22, 11:42
Published edit on patch set 14.
-
Markus Klein voted on patch set 15 CR +1 07/14/22, 11:43
-
core-ci voted on patch set 15 V +1 07/14/22, 11:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29139
-
core-ci voted on patch set 14 V +1 07/14/22, 11:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29138
-
core-ci voted on patch set 13 V +1 07/14/22, 11:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29137
-
Oliver Klee commented on patch set 15 07/14/22, 11:55
QuerySettingsInterface.php:135We can use this to let PHPStan know that it's the same instance: @return $this Also, we can have the QuerySettingsInterface native return type.Typo3QuerySettings.php:220Ditto.Typo3QuerySettingsTest.php:137I suggest the name setLanguageAspectHasFluentInterface instead (and would also be okay with the current name).Typo3QuerySettingsTest.php:139We should use assertSame instead so we know it's the same instance. -
Benni Mack commented on patch set 15 07/14/22, 13:49
QuerySettingsInterface.php:135Replythought about using native return types, but then I think this should apply and be done for all methods of this interface ("Harden QuerySettingsInterface") which would be much cleaner. However, IMHO this should be a separate patch then. -
Oliver Klee commented on patch set 15 CR -1 07/14/22, 13:52
QuerySettingsInterface.php:135ReplyI don't think that not having native return types should keep us from adding them for new methods. I would grudgingly okay with not adding the native return types for the new methods now (and prefer to add them now), but we should add the @return $this now for the new method. Otherwise, PHPStan will analyze new method incorrectly. -
Benni Mack uploaded patch set 16 07/14/22, 13:53
-
Benni Mack commented on patch set 15 07/14/22, 13:54
Typo3QuerySettings.php:220ReplyDoneTypo3QuerySettingsTest.php:137ReplyDoneTypo3QuerySettingsTest.php:139ReplyDone -
Oliver Klee commented on patch set 16 07/14/22, 13:54
Thanks, Benni! -
Benni Mack commented on patch set 16 07/14/22, 13:54
QuerySettingsInterface.php:135ReplyAnd I think: Somebody(tm) should do it separately - because: One concern at a time. -
core-ci voted on patch set 16 V -1 07/14/22, 14:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29149
-
Oliver Klee commented on patch set 16 07/14/22, 14:25
QuerySettingsInterface.php:135ReplyAck -
Benni Mack uploaded patch set 17 07/14/22, 15:16
-
core-ci voted on patch set 17 V +1 07/14/22, 15:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29154
-
Oliver Hader commented on patch set 17 07/14/22, 17:10
Typo3DbBackend.php:522I don't understand this `|| $languageAspect->getId() === 0;` yet.. -
Oli Bartsch commented on patch set 17 07/14/22, 18:01
Looks good to me!Typo3DbBackend.php:513Use $languageAspect here? -
Oli Bartsch voted on patch set 17 V +1 07/14/22, 18:02
-
Benni Mack uploaded patch set 18 07/14/22, 18:27
-
Benni Mack commented on patch set 17 07/14/22, 18:28
Typo3DbBackend.php:513ReplyDoneTypo3DbBackend.php:522Replyadded a bit more context to it. -
core-ci voted on patch set 18 V +1 07/14/22, 18:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29163
-
Oliver Hader voted on patch set 18 V +1 CR +1 07/14/22, 18:47
-
Oli Bartsch voted on patch set 18 V +1 CR +1 07/14/22, 18:48
-
Benni Mack commented on patch set 18 V +2 CR +2 07/14/22, 18:55
Typo3DbBackend.php:522ReplyDone -
Benni Mack merged patch set 19 07/14/22, 18:55