Review main Abandoned

75095[BUGFIX] Use FlexFormValueFormatter only where it's supposed to

Nikita Hovratov CR 0 V 0 Normal +44 −49 updated 07/12/22, 08:51

Commit message

The new FlexFormValueFormatter should only be used for diff
views. The format call is now extracted from the
`BackendUtility::getProcessedValue` method and used directly
where it's needed.

In addition, the nl2br call is removed in the workspaces
history view, because in #91148 the css value for
`white-space` has changed to `pre-wrap`, thus linebreaks are
displayed correctly even without <br> tags, and it avoids
double linebreaks, as nl2br doesn't remove "\n".

Review

  • Code review CR 0
  • Verified V 0

Issues 2

Files 4

Review log 1525

  1. Nikita Hovratov uploaded patch set 1 07/11/22, 09:02

  2. core-ci voted on patch set 1 V +1 07/11/22, 09:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28873

  3. Andreas Kienast updated the commit message in patch set 2 07/11/22, 09:38

  4. core-ci voted on patch set 2 V +1 07/11/22, 09:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28876

  5. Nikita Hovratov commented on patch set 2 07/11/22, 09:48

    Thanks^^
  6. Oli Bartsch commented on patch set 2 07/11/22, 10:48

    Thanks for taking care. Current patch does unfortunately not fully fix the issue. For example in the element information modal no cropping is applied, however the display is broken anyways. Not sure how many other places are affected as well. Especially because this is public API and usually used in custom extension code.
  7. Nikita Hovratov uploaded patch set 3 07/11/22, 11:34

  8. Nikita Hovratov commented on patch set 3 07/11/22, 11:34

    Reply

    Done
  9. core-ci voted on patch set 3 V +1 07/11/22, 11:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28881

  10. Nikita Hovratov uploaded patch set 4 07/11/22, 12:12

  11. core-ci voted on patch set 4 V +1 07/11/22, 12:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28883

  12. Nikita Hovratov uploaded patch set 5 07/11/22, 12:31

  13. core-ci voted on patch set 5 V +1 07/11/22, 12:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28884

  14. Nikita Hovratov uploaded patch set 6 07/11/22, 17:06

  15. Nikita Hovratov uploaded patch set 7 07/11/22, 17:11

  16. core-ci voted on patch set 6 V +1 07/11/22, 17:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28914

  17. core-ci voted on patch set 7 V +1 07/11/22, 17:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28916

  18. Nikita Hovratov uploaded patch set 8 07/11/22, 20:39

  19. core-ci voted on patch set 8 V -1 07/11/22, 20:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28920

  20. Nikita Hovratov uploaded patch set 9 07/11/22, 21:34

  21. core-ci voted on patch set 9 V +1 07/11/22, 21:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28924

  22. Nikita Hovratov uploaded patch set 10 07/11/22, 21:59

  23. core-ci voted on patch set 10 V +1 07/11/22, 22:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28925

  24. Oliver Hader commented on patch set 10 CR -1 07/12/22, 07:39

    blocked currently (due to upcoming maintenance releases today - July 12 2022)
  25. Nikita Hovratov abandoned the change 07/12/22, 08:51