Review main Merged

75099[BUGFIX] Ensure to use default UID for Extbase objects

Benni Mack CR +2 V +2 Normal +69 −55 updated 07/12/22, 16:07

Commit message

With this change, Extbase consistently
returns objects with a "uid" of the default language,
and not the localized ID, depending on the query settings.

This way, side effects related to the Persistence
Storage are removed, as the persistence session is storing
the UID + the localized UID as identifier.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 7

Review log 1621

  1. Benni Mack uploaded patch set 1 07/11/22, 13:36

  2. Mathias Brodala commented on patch set 1 07/11/22, 13:39

  3. core-ci voted on patch set 1 V -1 07/11/22, 13:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28889

  4. Benni Mack uploaded patch set 2 07/11/22, 14:27

  5. core-ci voted on patch set 2 V +1 07/11/22, 14:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28894

  6. Benni Mack uploaded patch set 3 07/11/22, 15:07

  7. Benni Mack commented on patch set 2 07/11/22, 15:08

    Reply

    I don't think so, but will have a look at your solution in the near future.
  8. Benni Mack commented on patch set 4 07/11/22, 15:10

    Published edit on patch set 3.
  9. core-ci voted on patch set 3 V +1 07/11/22, 15:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28896

  10. core-ci voted on patch set 4 V +1 07/11/22, 15:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28897

  11. Benni Mack commented on patch set 4 CR -2 07/11/22, 16:45

    will have to block this for now...
  12. Benni Mack voted on patch set 4 CR 0 07/11/22, 20:57

  13. Andreas Kienast commented on patch set 4 07/12/22, 06:08

    Important-59992-ExtbaseConsistentUidValuesFromPersistenceSession.rst:17

    ?
  14. Benni Mack commented on patch set 5 07/12/22, 07:04

    Published edit on patch set 4.
  15. Benni Mack commented on patch set 5 07/12/22, 07:09

    Important-59992-ExtbaseConsistentUidValuesFromPersistenceSession.rst:17 Reply

    Done
  16. core-ci voted on patch set 5 V +1 07/12/22, 07:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28932

  17. Andreas Kienast voted on patch set 5 CR +1 07/12/22, 14:10

  18. Andreas Kienast voted on patch set 5 V +1 07/12/22, 15:54

  19. Oli Bartsch voted on patch set 5 V +1 CR +1 07/12/22, 15:54

  20. Andreas Kienast voted on patch set 5 V +2 CR +2 07/12/22, 16:07

  21. Andreas Kienast merged patch set 6 07/12/22, 16:07