Review main Merged

75100[TASK] Simplify usage of LanguageAspect

Benni Mack CR +2 V +2 Easy +17 −8 updated 07/12/22, 07:42

Commit message

This is a precursor for several language-related
Extbase bugfixes, allowing to hand over a custom LanguageAspect
into PageRepository->getRecordOverlay()
instead of the legacy naming conventions.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 711

  1. Benni Mack uploaded patch set 1 07/11/22, 13:47

  2. core-ci voted on patch set 1 V -1 07/11/22, 13:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28891

  3. Benni Mack uploaded patch set 2 07/11/22, 15:19

  4. core-ci voted on patch set 2 V -1 07/11/22, 15:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28899

  5. Benni Mack commented on patch set 3 07/11/22, 15:34

    Published edit on patch set 2.
  6. core-ci voted on patch set 3 V +1 07/11/22, 15:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28901

  7. Benni Mack updated the commit message in patch set 4 07/12/22, 07:21

  8. core-ci voted on patch set 4 V +1 07/12/22, 07:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28935

  9. Oli Bartsch voted on patch set 4 V +1 CR +1 07/12/22, 07:33

  10. Andreas Kienast voted on patch set 4 V +2 CR +2 07/12/22, 07:42

  11. Andreas Kienast merged patch set 5 07/12/22, 07:42