75101[BUGFIX] Prevent resolving translated page with default slug
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Oliver Hader +1
- Susi Moog +1
- Benni Mack +1
-
Verified V +2 Done
- Stefan Bürk +2
- Susi Moog +1
- Benni Mack +1
- core-ci +1 CI
Issues 2
Files 3
Review log 3352
Show 1527 earlier messages
-
Stefan Bürk uploaded patch set 1 07/11/22, 14:18
-
Stefan Bürk updated the commit message in patch set 2 07/11/22, 14:21
-
core-ci voted on patch set 1 V -1 07/11/22, 14:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28892
-
core-ci voted on patch set 2 V -1 07/11/22, 14:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28893
-
Stefan Bürk uploaded patch set 3 07/12/22, 09:08
-
Stefan Bürk uploaded patch set 4 07/12/22, 09:10
-
core-ci voted on patch set 4 V -1 07/12/22, 09:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28956
-
core-ci voted on patch set 3 V -1 07/12/22, 09:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28954
-
Stefan Bürk uploaded patch set 5 07/12/22, 09:49
-
core-ci voted on patch set 5 V -1 07/12/22, 09:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28957
-
Stefan Bürk uploaded patch set 6 07/17/22, 12:52
-
core-ci voted on patch set 6 V +1 07/17/22, 12:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29316
-
Stefan Bürk rebased onto patch set 7 07/18/22, 21:15
-
core-ci voted on patch set 7 V +1 07/18/22, 21:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29339
-
Stefan Bürk rebased onto patch set 8 07/18/22, 21:38
-
core-ci voted on patch set 8 V +1 07/18/22, 21:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29341
-
Stefan Bürk uploaded patch set 9 07/30/22, 19:38
-
core-ci voted on patch set 9 V +1 07/30/22, 19:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29723
-
Sybille Peters updated the commit message in patch set 10 07/31/22, 04:56
-
core-ci voted on patch set 10 V +1 07/31/22, 05:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29737
-
Sybille Peters updated the commit message in patch set 11 07/31/22, 06:35
-
core-ci voted on patch set 11 V +1 07/31/22, 06:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29738
-
Stefan Bürk commented on patch set 11 CR -1 07/31/22, 07:32
Needs recheck - on it ... -
Stefan Bürk rebased onto patch set 12 09/13/22, 15:00
-
Stefan Bürk voted on patch set 12 CR -1 09/13/22, 15:00
-
core-ci voted on patch set 12 V +1 09/13/22, 15:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31058
-
Stefan Bürk rebased onto patch set 13 09/30/22, 07:43
-
core-ci voted on patch set 13 V +1 09/30/22, 07:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31738
-
Stefan Bürk voted on patch set 13 CR -1 09/30/22, 07:51
-
Stefan Bürk uploaded patch set 14 11/07/22, 14:09
-
core-ci voted on patch set 14 V +1 11/07/22, 14:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33207
-
Stefan Bürk voted on patch set 14 CR -1 11/07/22, 14:22
-
Stefan Bürk voted on patch set 14 CR 0 11/07/22, 16:12
-
Stefan Bürk commented on patch set 14 11/07/22, 16:17
Reply
Should be fine and fixes both cases. -
Benni Mack commented on patch set 14 CR -1 11/07/22, 19:54
This solution adds an additional SQL for each page candidate. It might be better to check (after the Route was fully matched and the PageArguments object was built) the language later-on. -
Stefan Bürk uploaded patch set 15 11/07/22, 21:56
-
Stefan Bürk uploaded patch set 16 11/07/22, 21:58
-
Stefan Bürk updated the commit message in patch set 17 11/07/22, 21:58
-
core-ci voted on patch set 15 V -1 11/07/22, 21:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33227
-
core-ci voted on patch set 17 V -1 11/07/22, 22:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33229
-
Stefan Bürk uploaded patch set 18 11/07/22, 22:13
-
core-ci voted on patch set 18 V +1 11/07/22, 22:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33230
-
Stefan Bürk uploaded patch set 19 11/08/22, 08:41
-
core-ci voted on patch set 19 V -1 11/08/22, 08:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33280
-
Stefan Bürk uploaded patch set 20 11/08/22, 09:41
-
core-ci voted on patch set 20 V +1 11/08/22, 09:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33283
-
Benni Mack voted on patch set 20 CR +1 11/08/22, 09:54
-
Benni Mack voted on patch set 20 V +1 11/08/22, 10:10
-
Oliver Hader voted on patch set 20 CR +1 11/08/22, 10:57
-
Susi Moog voted on patch set 20 V +1 CR +1 11/08/22, 11:04
-
Stefan Bürk voted on patch set 20 V +2 CR +2 11/08/22, 11:40
-
Stefan Bürk merged patch set 21 11/08/22, 11:40