Review main Merged

75101[BUGFIX] Prevent resolving translated page with default slug

Stefan Bürk CR +2 V +2 Hard +282 −4 updated 11/08/22, 11:40

Commit message

Default language page slug usage in combination with
the siteLanguage base of non-default language has been
resolved and delivering the language content. This made
the page accessible with multiple urls.

Available and existing translated pages should be only
resolved by the language slug, not the default language
page slug. However, if page is not translated, using the
default language slug for the resolving should be only
considered and working if fallback settings are provided.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Hader +1
    • Susi Moog +1
    • Benni Mack +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Susi Moog +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 3

Review log 3352

Show 1527 earlier messages
  1. Stefan Bürk uploaded patch set 1 07/11/22, 14:18

  2. Stefan Bürk updated the commit message in patch set 2 07/11/22, 14:21

  3. core-ci voted on patch set 1 V -1 07/11/22, 14:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28892

  4. core-ci voted on patch set 2 V -1 07/11/22, 14:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28893

  5. Stefan Bürk uploaded patch set 3 07/12/22, 09:08

  6. Stefan Bürk uploaded patch set 4 07/12/22, 09:10

  7. core-ci voted on patch set 4 V -1 07/12/22, 09:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28956

  8. core-ci voted on patch set 3 V -1 07/12/22, 09:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28954

  9. Stefan Bürk uploaded patch set 5 07/12/22, 09:49

  10. core-ci voted on patch set 5 V -1 07/12/22, 09:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28957

  11. Stefan Bürk uploaded patch set 6 07/17/22, 12:52

  12. core-ci voted on patch set 6 V +1 07/17/22, 12:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29316

  13. Stefan Bürk rebased onto patch set 7 07/18/22, 21:15

  14. core-ci voted on patch set 7 V +1 07/18/22, 21:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29339

  15. Stefan Bürk rebased onto patch set 8 07/18/22, 21:38

  16. core-ci voted on patch set 8 V +1 07/18/22, 21:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29341

  17. Stefan Bürk uploaded patch set 9 07/30/22, 19:38

  18. core-ci voted on patch set 9 V +1 07/30/22, 19:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29723

  19. Sybille Peters updated the commit message in patch set 10 07/31/22, 04:56

  20. core-ci voted on patch set 10 V +1 07/31/22, 05:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29737

  21. Sybille Peters updated the commit message in patch set 11 07/31/22, 06:35

  22. core-ci voted on patch set 11 V +1 07/31/22, 06:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29738

  23. Stefan Bürk commented on patch set 11 CR -1 07/31/22, 07:32

    Needs recheck - on it ...
  24. Stefan Bürk rebased onto patch set 12 09/13/22, 15:00

  25. Stefan Bürk voted on patch set 12 CR -1 09/13/22, 15:00

  26. core-ci voted on patch set 12 V +1 09/13/22, 15:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31058

  27. Stefan Bürk rebased onto patch set 13 09/30/22, 07:43

  1. core-ci voted on patch set 13 V +1 09/30/22, 07:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31738

  2. Stefan Bürk voted on patch set 13 CR -1 09/30/22, 07:51

  3. Stefan Bürk uploaded patch set 14 11/07/22, 14:09

  4. core-ci voted on patch set 14 V +1 11/07/22, 14:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33207

  5. Stefan Bürk voted on patch set 14 CR -1 11/07/22, 14:22

  6. Stefan Bürk voted on patch set 14 CR 0 11/07/22, 16:12

  7. Stefan Bürk commented on patch set 14 11/07/22, 16:17

    Reply

    Should be fine and fixes both cases.
  8. Benni Mack commented on patch set 14 CR -1 11/07/22, 19:54

    This solution adds an additional SQL for each page candidate. It might be better to check (after the Route was fully matched and the PageArguments object was built) the language later-on.
  9. Stefan Bürk uploaded patch set 15 11/07/22, 21:56

  10. Stefan Bürk uploaded patch set 16 11/07/22, 21:58

  11. Stefan Bürk updated the commit message in patch set 17 11/07/22, 21:58

  12. core-ci voted on patch set 15 V -1 11/07/22, 21:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33227

  13. core-ci voted on patch set 17 V -1 11/07/22, 22:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33229

  14. Stefan Bürk uploaded patch set 18 11/07/22, 22:13

  15. core-ci voted on patch set 18 V +1 11/07/22, 22:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33230

  16. Stefan Bürk uploaded patch set 19 11/08/22, 08:41

  17. core-ci voted on patch set 19 V -1 11/08/22, 08:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33280

  18. Stefan Bürk uploaded patch set 20 11/08/22, 09:41

  19. core-ci voted on patch set 20 V +1 11/08/22, 09:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33283

  20. Benni Mack voted on patch set 20 CR +1 11/08/22, 09:54

  21. Benni Mack voted on patch set 20 V +1 11/08/22, 10:10

  22. Oliver Hader voted on patch set 20 CR +1 11/08/22, 10:57

  23. Susi Moog voted on patch set 20 V +1 CR +1 11/08/22, 11:04

  24. Stefan Bürk voted on patch set 20 V +2 CR +2 11/08/22, 11:40

  25. Stefan Bürk merged patch set 21 11/08/22, 11:40