Review 11.5 Abandoned

75109[BUGFIX] Use FlexFormValueFormatter only where it's supposed to

Nikita Hovratov CR 0 V 0 Normal +48 −32 updated 07/12/22, 07:59

Commit message

The new FlexFormValueFormatter should only be used for diff
views. The format call is now extracted from the
`BackendUtility::getProcessedValue` method and used directly
where it's needed.

In addition, the nl2br call is removed in the workspaces
history view, because in #91148 the css value for
`white-space` has changed to `pre-wrap`, thus linebreaks are
displayed correctly even without <br> tags, and it avoids
double linebreaks, as nl2br doesn't remove "\n".

Review

  • Code review CR 0
  • Verified V 0

Issues 2

Files 4

Review log 35

  1. Nikita Hovratov uploaded patch set 1 07/11/22, 16:49

  2. core-ci voted on patch set 1 V -1 07/11/22, 17:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28911

  3. Nikita Hovratov uploaded patch set 2 07/11/22, 17:13

  4. core-ci voted on patch set 2 V +1 07/11/22, 17:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28917

  5. Nikita Hovratov abandoned the change 07/12/22, 07:59