Review main Merged

75116[BUGFIX] Allow changing FF sections in new version overlays

Christian Kuhn CR +2 V +2 Expert +1262 −7 updated 07/15/22, 13:43

Commit message

Creating a version overlay of a record that has flexform
sections and moving or deleting some of these sections
at the same time fails in DataHandler due to a wrong uid
lookup for the section command array.

The patch fixes this scenario in the DataHandler flexform
processing code and leaves an according explanation comment.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Tina Westner +1
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Tina Westner +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 25

Show 5 more files

Review log 1013

  1. Christian Kuhn uploaded patch set 1 07/12/22, 07:56

  2. core-ci voted on patch set 1 V +1 07/12/22, 08:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28942

  3. Christian Kuhn uploaded patch set 2 07/12/22, 10:45

  4. core-ci voted on patch set 2 V -1 07/12/22, 10:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28963

  5. Christian Kuhn uploaded patch set 3 07/12/22, 10:55

  6. core-ci voted on patch set 3 V +1 07/12/22, 11:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28964

  7. Christian Kuhn commented on patch set 3 CR -1 07/12/22, 11:14

    minor details ...
  8. Christian Kuhn commented on patch set 3 CR 0 07/12/22, 11:17

    it's fine.
  9. Benni Mack voted on patch set 3 V +1 CR +1 07/12/22, 11:57

  10. Stefan Bürk voted on patch set 3 CR +1 07/12/22, 12:09

  11. Tina Westner voted on patch set 3 V +1 CR +1 07/15/22, 11:11

  12. Christian Kuhn voted on patch set 3 V +2 CR +2 07/15/22, 13:43

  13. Christian Kuhn merged patch set 4 07/15/22, 13:43