Review main Merged

75117[BUGFIX] Display human-readable preview of FlexForm values

Nikita Hovratov CR +2 V +2 Hard +667 −81 updated 10/23/23, 10:32

Commit message

This change transforms the processed record of FlexForms
into a human-readable format.

This is especially useful when comparing changes in the
history module or the workspaces diff view.

The diff needs to be formatted with line breaks and tabs as
the output is passed through "htmlspecialchars" before it
will be displayed.

The white-space css setting needs to be changed to
"pre-wrap", because this is the only setting where line
breaks and tabs are kept and the text will still be
word-wrapped.

Review

  • Code review CR +2 Done
    • Nikita Hovratov +2
    • Anja Leichsenring +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Nikita Hovratov +2
    • Anja Leichsenring +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 14

Review log 4161

Show 2036 earlier messages
  1. Nikita Hovratov uploaded patch set 1 07/12/22, 08:47

  2. Nikita Hovratov commented on patch set 1 07/12/22, 08:50

    This is the second attempt after reverting https://review.typo3.org/c/Packages/TYPO3.CMS/+/64260 due to side effects. It combines all post-fixes, which were done after the initial merge.
  3. core-ci voted on patch set 1 V +1 07/12/22, 08:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28948

  4. Nikita Hovratov uploaded patch set 2 07/27/22, 15:00

  5. core-ci voted on patch set 2 V -1 07/27/22, 15:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29621

  6. Nikita Hovratov uploaded patch set 3 07/27/22, 15:15

  7. core-ci voted on patch set 3 V +1 07/27/22, 15:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29624

  8. Simon Schaufelberger uploaded patch set 4 08/03/22, 20:45

  9. core-ci voted on patch set 4 V -1 08/03/22, 20:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29801

  10. Simon Schaufelberger uploaded patch set 5 08/03/22, 21:08

  11. core-ci voted on patch set 5 V -1 08/03/22, 21:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29805

  12. Simon Schaufelberger uploaded patch set 6 08/03/22, 21:27

  13. core-ci voted on patch set 6 V +1 08/03/22, 21:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29808

  14. Nikita Hovratov uploaded patch set 7 09/28/22, 08:56

  15. core-ci voted on patch set 7 V -1 09/28/22, 09:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31640

  16. Nikita Hovratov uploaded patch set 8 09/28/22, 10:04

  17. core-ci voted on patch set 8 V -1 09/28/22, 10:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31646

  18. Nikita Hovratov uploaded patch set 9 10/21/22, 22:16

  19. core-ci voted on patch set 9 V -1 10/21/22, 22:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32608

  20. Nikita Hovratov uploaded patch set 10 10/22/22, 15:57

  21. core-ci voted on patch set 10 V +1 10/22/22, 16:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32620

  22. Nikita Hovratov uploaded patch set 11 V +1 02/04/23, 01:09

  23. core-ci voted on patch set 11 V +1 02/04/23, 01:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37020

  24. Nikita Hovratov uploaded patch set 12 V +1 02/04/23, 01:44

  25. core-ci voted on patch set 12 V +1 02/04/23, 01:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37023

  26. Benni Mack commented on patch set 12 02/04/23, 21:13

    Hey Nikita, let's move the recurring code into DiffUtility with a new public method. OK?
  27. Nikita Hovratov uploaded patch set 13 V +1 02/04/23, 23:59

  28. Nikita Hovratov commented on patch set 13 02/05/23, 00:01

    Reply

    Like this? I just added a new parameter for now with a new enum.
  29. core-ci voted on patch set 13 V -1 02/05/23, 00:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37085

  30. Nikita Hovratov uploaded patch set 14 V -1 02/05/23, 12:27

  31. core-ci voted on patch set 14 V -1 02/05/23, 12:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37105

  32. Nikita Hovratov uploaded patch set 15 V -1 02/05/23, 13:02

  33. core-ci voted on patch set 15 V +1 02/05/23, 13:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37108

  34. Benni Mack uploaded patch set 16 V +1 02/06/23, 08:38

  35. core-ci voted on patch set 16 V +1 02/06/23, 08:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37142

  36. Benni Mack updated the commit message in patch set 17 V +1 05/03/23, 09:56

  1. Nikita Hovratov uploaded patch set 18 07/29/23, 21:05

  2. core-ci voted on patch set 18 V -1 07/29/23, 21:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44739

  3. Nikita Hovratov uploaded patch set 19 V -1 07/29/23, 21:20

  4. core-ci voted on patch set 19 V +1 07/29/23, 21:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44740

  5. Anja Leichsenring rebased onto patch set 20 V +1 08/02/23, 08:46

  6. Anja Leichsenring voted on patch set 20 V +1 CR +1 08/02/23, 08:46

  7. core-ci voted on patch set 20 V +1 08/02/23, 08:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44868

  8. Simon Schaufelberger voted on patch set 20 V +1 CR +1 08/13/23, 15:51

  9. Benjamin Franzke commented on patch set 20 09/13/23, 14:22

    should this be merged into v12?
  10. Nikita Hovratov commented on patch set 20 09/13/23, 14:37

    Reply

    I'm uncertain, as this is quite a huge patch and we did a revert in v11 for this in the past. I'm more comfortable with main only, as there is more time to find possible bugs.
  11. Simon Schaufelberger commented on patch set 20 09/13/23, 21:26

    Reply

    on the other hand, only very few people use main branch to test things while the user base of v12 is much bigger. personally i would add it to v12 as well and get some feedback if something doesn't work as expected than later in v13 which is still a very long time to be released
  12. Simon Schaufelberger commented on patch set 20 09/13/23, 21:33

    Reply

    if it must go into v13 only, I would rather label it as a feature than a bugfix.
  13. Nikita Hovratov commented on patch set 20 09/13/23, 22:26

    Reply

    Then I would need to write a feature rst 😄
  14. Simon Schaufelberger commented on patch set 20 09/24/23, 21:21

    Reply

    Nikita, can I give you a bit more confidence that we can also bring this into v12? This would be a great benefit. According to https://www.t3versions.com/statistics-detail/21 v12 is only used on very few websites actually. Most are still on 10 and 11.
  15. Stefan Bürk commented on patch set 20 CR -1 09/26/23, 08:59

    The patch seems to be broken again, see details in the issue on forge: https://forge.typo3.org/issues/91148#note-64 For me it looks like the line breaks are missing in the Workspace -> View Changes view (see attached image in the issue / note-64). @Nikita can you please recheck/confirm this ?
  16. Simon Schaufelberger commented on patch set 20 09/29/23, 21:43

    Reply

    I made some changes in a workspace and then went to the workspace modul and clicked on the "i" button and everything looks as expected.
  17. Stefan Bürk commented on patch set 20 10/04/23, 12:27

    Reply

    I already talked with nikita before adding the screenshots (showed them to him in slack). Nope, the behaviour is not like intented. He wanted to recheck that. Therefore, -1 staying until that.
  18. Nikita Hovratov uploaded patch set 21 CR +1 V +1 10/20/23, 18:04

  19. Nikita Hovratov commented on patch set 21 10/20/23, 18:05

    Reply

    Done

    Reply

    Done
  20. Nikita Hovratov commented on patch set 21 10/20/23, 18:06

    First draft of this patch is from Jan 2020. Let's get this in now.. 😊
  21. core-ci voted on patch set 21 V +1 10/20/23, 18:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47989

  22. Anja Leichsenring voted on patch set 21 V +1 CR +1 10/23/23, 04:16

  23. Stefan Bürk voted on patch set 21 V +1 CR +1 10/23/23, 08:23

  24. Nikita Hovratov voted on patch set 21 V +2 CR +2 10/23/23, 10:31

  25. Nikita Hovratov merged patch set 22 10/23/23, 10:32