Review main Merged Breaking

75123[!!!][TASK] Remove TCA option "cruser_id"

Benni Mack CR +2 V +2 Expert +501 −566 updated 07/26/22, 17:13

Commit message

TYPO3's TCA definition has a setting called `cruser_id`
which automatically is filled with the current TYPO3's
Backend User ID, if created via DataHandler.

However, this information is also available in the
RecordHistory (since its extraction from sys_log in v9)
and can be queried, when needed, directly from there.

This way, all TCA-based tables, having the setting "cruser_id"
do not need to carry this value anymore, as it is duplicated
in TYPO3's data model.

This change removes the evaluation of "cruser_id",
and removes the filling of this property via DataHandler.

The DB field is also not set anymore automatically.

The Info popup (ElementInformationController) now
shows the information from the RecordHistory information.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 107

Show 87 more files

Review log 1526

Show 1 earlier messages
  1. Benni Mack uploaded patch set 1 07/12/22, 09:57

  1. core-ci voted on patch set 1 V -1 07/12/22, 10:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28958

  2. Benni Mack uploaded patch set 2 07/12/22, 10:36

  3. core-ci voted on patch set 2 V -1 07/12/22, 10:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28961

  4. Benni Mack uploaded patch set 3 07/14/22, 15:39

  5. core-ci voted on patch set 3 V -1 07/14/22, 15:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29156

  6. Benni Mack uploaded patch set 4 07/14/22, 16:21

  7. core-ci voted on patch set 4 V -1 07/14/22, 16:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29158

  8. Benni Mack rebased onto patch set 5 07/15/22, 08:48

  9. core-ci voted on patch set 5 V -1 07/15/22, 08:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29189

  10. Christian Kuhn uploaded patch set 6 07/26/22, 09:11

  11. core-ci voted on patch set 6 V -1 07/26/22, 09:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29540

  12. Christian Kuhn uploaded patch set 7 07/26/22, 13:41

  13. core-ci voted on patch set 7 V +1 07/26/22, 13:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29544

  14. Christian Kuhn uploaded patch set 8 07/26/22, 14:00

  15. core-ci voted on patch set 8 V +1 07/26/22, 14:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29545

  16. Christian Kuhn uploaded patch set 9 07/26/22, 14:33

  17. core-ci voted on patch set 9 V -1 07/26/22, 14:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29546

  18. Benni Mack uploaded patch set 10 07/26/22, 15:16

  19. Christian Kuhn commented on patch set 10 CR -1 07/26/22, 15:22

    will push again.
  20. Christian Kuhn uploaded patch set 11 07/26/22, 15:24

  21. core-ci voted on patch set 10 V -1 07/26/22, 15:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29550

  22. core-ci voted on patch set 11 V +1 07/26/22, 15:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29551

  23. Christian Kuhn voted on patch set 11 V +1 CR +1 07/26/22, 15:46

  24. Stefan Bürk voted on patch set 11 V +2 CR +2 07/26/22, 17:13

  25. Stefan Bürk merged patch set 12 07/26/22, 17:13