75126[BUGFIX] Add check if opcache_invalidate exists
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Christian Kuhn +1
-
Verified V +2 Done
- Andreas Kienast +2
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1216
-
Shehfinaz Kadavil uploaded patch set 1 07/12/22, 11:59
-
Shehfinaz Kadavil updated the commit message in patch set 2 07/12/22, 12:05
-
core-ci voted on patch set 1 V +1 07/12/22, 12:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28968
-
core-ci voted on patch set 2 V +1 07/12/22, 12:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28969
-
Christian Kuhn uploaded patch set 3 07/12/22, 13:53
-
Christian Kuhn commented on patch set 3 07/12/22, 13:54
thanks for the patch! i tuned a bit by turning the condition around and adding some minor cleanups along the way. hope that is fine. -
Christian Kuhn updated the commit message in patch set 4 07/12/22, 13:54
-
core-ci voted on patch set 4 V +1 07/12/22, 14:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28982
-
core-ci voted on patch set 3 V +1 07/12/22, 14:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28981
-
Andreas Kienast voted on patch set 4 CR +1 07/12/22, 16:08
-
Christian Kuhn voted on patch set 4 V +1 CR +1 07/12/22, 17:06
-
Andreas Kienast voted on patch set 4 V +2 CR +2 07/12/22, 17:07
-
Andreas Kienast merged patch set 5 07/12/22, 17:07
-
Stefan Bürk commented on patch set 5 07/12/22, 17:12
OpcodeCacheService.php:76Post - should function_exists() not be done for opcache_reset also to be consinstent ? -
Christian Kuhn commented on patch set 5 07/12/22, 17:19
OpcodeCacheService.php:76Replylet's wait for a bug report in case this really is an issue. -
Shehfinaz Kadavil commented on patch set 5 07/13/22, 07:08
Reply
Thanks :)