Review main Merged

75126[BUGFIX] Add check if opcache_invalidate exists

Shehfinaz Kadavil CR +2 V +2 Easy +6 −8 updated 07/13/22, 07:10

Commit message

The existing condition checks if opcache_invalidate
and opcache_reset are disabled, the new condition
also checks if the function opcache_invalidate exists.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1216

  1. Shehfinaz Kadavil uploaded patch set 1 07/12/22, 11:59

  2. Shehfinaz Kadavil updated the commit message in patch set 2 07/12/22, 12:05

  3. core-ci voted on patch set 1 V +1 07/12/22, 12:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28968

  4. core-ci voted on patch set 2 V +1 07/12/22, 12:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28969

  5. Christian Kuhn uploaded patch set 3 07/12/22, 13:53

  6. Christian Kuhn commented on patch set 3 07/12/22, 13:54

    thanks for the patch! i tuned a bit by turning the condition around and adding some minor cleanups along the way. hope that is fine.
  7. Christian Kuhn updated the commit message in patch set 4 07/12/22, 13:54

  8. core-ci voted on patch set 4 V +1 07/12/22, 14:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28982

  9. core-ci voted on patch set 3 V +1 07/12/22, 14:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28981

  10. Andreas Kienast voted on patch set 4 CR +1 07/12/22, 16:08

  11. Christian Kuhn voted on patch set 4 V +1 CR +1 07/12/22, 17:06

  12. Andreas Kienast voted on patch set 4 V +2 CR +2 07/12/22, 17:07

  13. Andreas Kienast merged patch set 5 07/12/22, 17:07

  14. Stefan Bürk commented on patch set 5 07/12/22, 17:12

    OpcodeCacheService.php:76

    Post - should function_exists() not be done for opcache_reset also to be consinstent ?
  15. Christian Kuhn commented on patch set 5 07/12/22, 17:19

    OpcodeCacheService.php:76 Reply

    let's wait for a bug report in case this really is an issue.
  16. Shehfinaz Kadavil commented on patch set 5 07/13/22, 07:08

    Reply

    Thanks :)