Review main Merged

75152[TASK] Have local acceptance test setup files

Christian Kuhn CR +2 V +2 Hard +326 −12 updated 07/12/22, 17:20

Commit message

The 'installer' acceptance test related environment setup
files have been part of typo3/testing-framework, but they
should be part of ext:core since they're core monorepo
specific and not a concern of the general testing-framework.

The patch moves the codeception environment setup files from
TF to core and raises TF which removed them already.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 7

Review log 1215

  1. Christian Kuhn uploaded patch set 1 07/12/22, 16:43

  2. Christian Kuhn updated the commit message in patch set 2 07/12/22, 16:45

  3. Anja Leichsenring voted on patch set 2 V +1 CR +1 07/12/22, 16:48

  4. Stefan Bürk voted on patch set 2 V +1 CR +1 07/12/22, 16:51

  5. core-ci voted on patch set 1 V -1 07/12/22, 16:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28993

  6. core-ci voted on patch set 2 V -1 07/12/22, 16:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28994

  7. Stefan Bürk commented on patch set 2 07/12/22, 16:55

    now we know why integration tests are important - s install tests with same exception code ;)
  8. Stefan Bürk commented on patch set 2 CR -1 07/12/22, 17:03

    on it
  9. Christian Kuhn commented on patch set 2 07/12/22, 17:06

    haha. thx for fixing.
  10. Stefan Bürk uploaded patch set 3 07/12/22, 17:09

  11. Anja Leichsenring voted on patch set 3 V +1 CR +1 07/12/22, 17:17

  12. core-ci voted on patch set 3 V +1 07/12/22, 17:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29000

  13. Stefan Bürk voted on patch set 3 V +1 CR +1 07/12/22, 17:18

  14. Christian Kuhn voted on patch set 3 V +2 CR +2 07/12/22, 17:20

  15. Christian Kuhn merged patch set 4 07/12/22, 17:20