Review main Merged

75154[TASK] Use Command::* constants for return values

Andreas Kienast CR +2 V +2 Normal +54 −54 updated 07/12/22, 20:27

Commit message

Since Symfony 5.x, the Command class offers constants for possible
return values to be used in a commands `execute()` method.

All commands are adjusted.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • core-ci +1 CI

Issues 1

Files 31

Show 11 more files

Review log 710

  1. Andreas Kienast uploaded patch set 1 07/12/22, 17:37

  2. core-ci voted on patch set 1 V +1 07/12/22, 17:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29003

  3. Oli Bartsch uploaded patch set 2 07/12/22, 19:08

  4. Oli Bartsch rebased onto patch set 3 07/12/22, 19:08

  5. Oli Bartsch voted on patch set 3 V +1 CR +1 07/12/22, 19:09

  6. core-ci voted on patch set 2 V +1 07/12/22, 19:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29009

  7. core-ci voted on patch set 3 V +1 07/12/22, 19:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29010

  8. Jochen Roth voted on patch set 3 V +1 CR +1 07/12/22, 19:26

  9. Oli Bartsch voted on patch set 3 V +2 CR +2 07/12/22, 20:27

  10. Oli Bartsch merged patch set 4 07/12/22, 20:27