Review main Merged

75156[TASK] Switch from xml imports to csv in acceptance tests

Christian Kuhn CR +2 V +2 Hard +96 −444 updated 07/13/22, 07:08

Commit message

The acceptance test base class in testing-framework
now allows to load .csv instead of .xml files to
prime the database with records.

These files are easier to read and maintain and we
avoid a fixture dependency to the testing-framework
this way.

$ composer req --dev typo3/testing-framework:dev-main

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 6

Review log 1016

  1. Christian Kuhn uploaded patch set 1 07/12/22, 18:52

  2. core-ci voted on patch set 1 V -1 07/12/22, 19:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29007

  3. Christian Kuhn uploaded patch set 2 07/13/22, 05:48

  4. core-ci voted on patch set 2 V +1 07/13/22, 05:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29026

  5. Christian Kuhn uploaded patch set 3 07/13/22, 05:57

  6. core-ci voted on patch set 3 V +1 07/13/22, 06:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29027

  7. Christian Kuhn uploaded patch set 4 07/13/22, 06:33

  8. core-ci voted on patch set 4 V +1 07/13/22, 06:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29031

  9. Christian Kuhn uploaded patch set 5 07/13/22, 06:51

  10. Christian Kuhn updated the commit message in patch set 6 07/13/22, 06:52

  11. Benni Mack voted on patch set 6 V +1 CR +1 07/13/22, 06:59

  12. core-ci voted on patch set 6 V +1 07/13/22, 07:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29033

  13. Stefan Bürk voted on patch set 6 V +1 CR +1 07/13/22, 07:01

  14. core-ci voted on patch set 5 V +1 07/13/22, 07:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29032

  15. Christian Kuhn voted on patch set 6 V +2 CR +2 07/13/22, 07:08

  16. Christian Kuhn merged patch set 7 07/13/22, 07:08