75163[FEATURE] Improve performance and usability while editing sys_filemounts
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Christian Kuhn +1
-
Verified V +2 Done
- Benni Mack +2
- Oli Bartsch +1
- core-ci +1 CI
Issues 2
Files 18
- typo3/sysext/core/Classes/Authentication/BackendUserAuthentication.php+5 −3
- typo3/sysext/core/Classes/Resource/Search/QueryRestrictions/FolderMountsRestriction.php+1 −1
- typo3/sysext/core/Classes/Resource/Security/StoragePermissionsAspect.php2+4 −2
- typo3/sysext/core/Classes/Resource/Service/UserFileMountService.php+1 −6
- typo3/sysext/core/Classes/Resource/SynchronizeFolderRelations.php3+5 −5
- typo3/sysext/core/Configuration/TCA/sys_filemounts.php2+6 −26
- typo3/sysext/core/Documentation/Changelog/12.0/Feature-97922-ImprovePerformanceAndUsabilityWhileEditingSys_filemounts.rstnew+34 −0
- typo3/sysext/core/Resources/Private/Language/locallang_tca.xlf5+3 −12
- typo3/sysext/core/Tests/Functional/Resource/Fixtures/FilemountsBase.csv2+12 −10
- typo3/sysext/core/Tests/Functional/Resource/Fixtures/FilemountsResult.csv+12 −10
- typo3/sysext/core/Tests/Functional/Resource/SynchronizeFolderRelationsTest.php+1 −1
- typo3/sysext/core/Tests/Functional/Tca/FilemountsVisibleFieldsTest.phpdeleted+0 −54
- typo3/sysext/core/ext_tables.sql+1 −2
- typo3/sysext/install/Classes/Updates/SysFileMountIdentifierMigration.php13new+114 −0
- typo3/sysext/install/Tests/Functional/Updates/Fixtures/FilemountsBase.csvnew+8 −0
- typo3/sysext/install/Tests/Functional/Updates/Fixtures/FilemountsMigrated.csvnew+8 −0
- typo3/sysext/install/Tests/Functional/Updates/SysFileMountIdentifierMigrationTest.phpnew+67 −0
- typo3/sysext/install/ext_localconf.php+2 −0
Review log 3447
Show 1622 earlier messages
-
Frank Nägler uploaded patch set 1 07/13/22, 08:57
-
core-ci voted on patch set 1 V -1 07/13/22, 09:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29042
-
Frank Nägler uploaded patch set 2 07/13/22, 09:30
-
core-ci voted on patch set 2 V +1 07/13/22, 09:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29044
-
Frank Nägler uploaded patch set 3 07/13/22, 10:22
-
core-ci voted on patch set 3 V +1 07/13/22, 10:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29051
-
Frank Nägler uploaded patch set 4 07/13/22, 10:33
-
Frank Nägler marked it ready for review 07/13/22, 10:34
-
core-ci voted on patch set 4 V +1 07/13/22, 10:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29053
-
Benni Mack commented on patch set 4 07/13/22, 11:12
FilemountsResult.csv.new:2strange filename... -
Frank Nägler commented on patch set 4 07/13/22, 11:38
SynchronizeFolderRelations.php:121ReplyI hate simple string concatenation :D Anyway, what is the core way here?FilemountsResult.csv.new:2Replythat is a mistake, I will fix it. -
Benni Mack commented on patch set 4 07/13/22, 12:27
can you change this to "Resolves: #" -
Frank Nägler uploaded patch set 5 07/13/22, 12:28
-
Frank Nägler commented on patch set 5 07/13/22, 12:29
SynchronizeFolderRelations.php:121ReplyAck -
Frank Nägler updated the commit message in patch set 6 07/13/22, 12:30
-
Frank Nägler commented on patch set 5 07/13/22, 12:30
Reply
Ack -
core-ci voted on patch set 5 V +1 07/13/22, 12:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29060
-
core-ci voted on patch set 6 V +1 07/13/22, 12:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29061
-
Christian Kuhn commented on patch set 6 07/13/22, 13:08
could you add a "why?" explanation to the commit message? it's not clear to me why we denormalize these fields. it looks as if base and path are still kept, so the new field now needs to be kept in sync. i think we should have well reasoned explanation to take these additional sync and data duplication risks. will base+path vanish? what do you think?FilemountsBase.csv:6what happens when there are one or multiple colon in 'path' part? add some dedicated tests to proof that still explodes as expected? -
Christian Kuhn commented on patch set 6 CR -1 07/13/22, 13:10
StoragePermissionsAspect.php:65fails when 'path' part has a colon. -
Frank Nägler uploaded patch set 7 07/13/22, 14:09
-
Benni Mack commented on patch set 7 07/13/22, 14:13
StoragePermissionsAspect.php:65ReplyDoneFilemountsResult.csv.new:2ReplyDone
-
Benni Mack commented on patch set 7 07/13/22, 14:13
FilemountsBase.csv:6ReplyDone -
Andreas Kienast commented on patch set 7 CR -1 07/13/22, 14:22
on it -
core-ci voted on patch set 7 V +1 07/13/22, 14:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29066
-
Andreas Kienast uploaded patch set 8 07/13/22, 14:26
-
Oli Bartsch commented on patch set 8 07/13/22, 14:34
sys_filemounts.php:62This did actually not work for me. Record could be saved without a folder selected.locallang_tca.xlf:286Not quite sure about the naming here. What do you think about "Mount point" or sth. like "Base identifier"?locallang_tca.xlf:291Should we remove the unused labels?SysFileMountIdentifierMigration.php:20This import is currently unused.SysFileMountIdentifierMigration.php:25Upgrade wizards should usually be well tested.SysFileMountIdentifierMigration.php:51We only need those having 'base' and 'path' set, while 'identifier' is not set. Vice versa in updateNecessary().SysFileMountIdentifierMigration.php:66Is this save on all DBMS? Any reason for not using query builder here?SysFileMountIdentifierMigration.php:71This could be prevented by checking for the existence of the column, using the schema manager. -
core-ci voted on patch set 8 V -1 07/13/22, 14:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29068
-
Andreas Kienast uploaded patch set 9 07/13/22, 14:36
-
core-ci voted on patch set 9 V +1 07/13/22, 14:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29070
-
Christian Kuhn commented on patch set 9 07/13/22, 14:45
locallang_tca.xlf:291Replyyes please. -
Andreas Kienast commented on patch set 9 CR -1 07/13/22, 14:50
on it again -
Andreas Kienast uploaded patch set 10 07/13/22, 15:31
-
core-ci voted on patch set 10 V +1 07/13/22, 15:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29074
-
Oli Bartsch uploaded patch set 11 07/13/22, 18:43
-
Oli Bartsch commented on patch set 11 07/13/22, 18:45
Reply
Donesys_filemounts.php:62ReplyDonelocallang_tca.xlf:286ReplyDonelocallang_tca.xlf:291ReplyDoneSysFileMountIdentifierMigration.php:20ReplyDoneSysFileMountIdentifierMigration.php:20ReplyDoneSysFileMountIdentifierMigration.php:25ReplyDoneSysFileMountIdentifierMigration.php:51ReplyDoneSysFileMountIdentifierMigration.php:66ReplyDoneSysFileMountIdentifierMigration.php:71ReplyDone -
core-ci voted on patch set 11 V +1 07/13/22, 18:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29086
-
Oli Bartsch commented on patch set 11 V +1 CR +1 07/13/22, 18:51
SysFileMountIdentifierMigration.php:102We might want to skip records with base=0 since this is IMO not a valid base for a file mount. However, since we don't do sanity checks here at all, I would also be fine with skipping the following condition (just wanted to mention it): $queryBuilder->expr()->gt('base', $queryBuilder->createNamedParameter(0, \PDO::PARAM_INT)) -
Benni Mack uploaded patch set 12 07/13/22, 19:11
-
Benni Mack commented on patch set 12 V +1 CR +1 07/13/22, 19:12
SysFileMountIdentifierMigration.php:102ReplyDone -
Oli Bartsch uploaded patch set 13 07/13/22, 19:19
-
Oli Bartsch voted on patch set 13 V +1 CR +1 07/13/22, 19:19
-
Christian Kuhn commented on patch set 13 CR +1 07/13/22, 19:20
this reads good! thx! -
core-ci voted on patch set 12 V -1 07/13/22, 19:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29089
-
core-ci voted on patch set 13 V +1 07/13/22, 19:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29093
-
Benni Mack voted on patch set 13 V +2 CR +2 07/13/22, 19:31
-
Benni Mack merged patch set 14 07/13/22, 19:31
SynchronizeFolderRelations.php:121