Review main Merged

75165[TASK] Avoid importDataSet() in functional tests

Christian Kuhn CR +2 V +2 Hard +129 −232 updated 07/13/22, 12:32

Commit message

This avoids using importDataSet() in functional tests
using .xml fixture files from the testing framework.

Usages are converted to importCSVDataSet(), fixture
files are added as .csv to the according extension.

XML handling in functional tests is now down to
setUpBackendUserFromFixture() which will be prepared
in testing-framework and adapted in core with another
patch.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 40

Show 20 more files

Review log 1016

  1. Christian Kuhn uploaded patch set 1 07/13/22, 09:38

  2. core-ci voted on patch set 1 V +1 07/13/22, 09:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29046

  3. Christian Kuhn uploaded patch set 2 07/13/22, 10:02

  4. core-ci voted on patch set 2 V -1 07/13/22, 10:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29048

  5. Christian Kuhn uploaded patch set 3 07/13/22, 10:19

  6. Christian Kuhn uploaded patch set 4 07/13/22, 10:28

  7. core-ci voted on patch set 3 V -1 07/13/22, 10:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29050

  8. core-ci voted on patch set 4 V +1 07/13/22, 10:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29052

  9. Christian Kuhn uploaded patch set 5 07/13/22, 11:22

  10. core-ci voted on patch set 5 V -1 07/13/22, 11:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29057

  11. Christian Kuhn uploaded patch set 6 07/13/22, 11:45

  12. core-ci voted on patch set 6 V +1 07/13/22, 11:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29059

  13. Benni Mack voted on patch set 6 V +1 CR +1 07/13/22, 12:02

  14. Stefan Bürk voted on patch set 6 V +1 CR +1 07/13/22, 12:32

  15. Christian Kuhn voted on patch set 6 V +2 CR +2 07/13/22, 12:32

  16. Christian Kuhn merged patch set 7 07/13/22, 12:32