75168[TASK] Avoid setUpBackendUserFromFixture() in functionals
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Benni Mack +1
-
Verified V +2 Done
- Stefan Bürk +2
- Benni Mack +1
- core-ci +1 CI
Issues 2
Files 111
- Build/phpstan/phpstan-baseline.neon+0 −5
- typo3/sysext/backend/Tests/Functional/Backend/Shortcut/ShortcutRepositoryTest.php+2 −2
- typo3/sysext/backend/Tests/Functional/Clipboard/ClipboardTest.php+2 −1
- typo3/sysext/backend/Tests/Functional/Controller/Page/Fixtures/be_users.csvnew+6 −0
- typo3/sysext/backend/Tests/Functional/Controller/Page/TreeControllerTest.php+3 −6
- typo3/sysext/backend/Tests/Functional/Controller/BackendControllerTest.php+2 −1
- typo3/sysext/backend/Tests/Functional/Controller/EditDocumentControllerTest.php+2 −2
- typo3/sysext/backend/Tests/Functional/Controller/FormInlineAjaxControllerTest.php+2 −2
- typo3/sysext/backend/Tests/Functional/Controller/MfaAjaxControllerTest.php+2 −3
- typo3/sysext/backend/Tests/Functional/Controller/MfaConfigurationControllerTest.php+2 −1
- typo3/sysext/backend/Tests/Functional/Controller/MfaControllerTest.php+2 −1
- typo3/sysext/backend/Tests/Functional/Controller/MfaSetupControllerTest.php+2 −1
- typo3/sysext/backend/Tests/Functional/Controller/ShortcutControllerTest.php+2 −2
- typo3/sysext/backend/Tests/Functional/Domain/Repository/Localization/LocalizationRepositoryTest.php+2 −2
- typo3/sysext/backend/Tests/Functional/Fixtures/be_users.csvnew+4 −0
- typo3/sysext/backend/Tests/Functional/Fixtures/be_users_mfa.csvnew+7 −0
- typo3/sysext/backend/Tests/Functional/Form/FormDataProvider/TcaCategoryTest.php+2 −1
- typo3/sysext/backend/Tests/Functional/Form/FormDataProvider/TcaGroupTest.php+2 −1
- typo3/sysext/backend/Tests/Functional/Middleware/BackendModuleValidatorTest.php+2 −1
- typo3/sysext/backend/Tests/Functional/Template/Components/Buttons/Action/ShortcutButtonTest.php+4 −2
Show 91 more files
- typo3/sysext/backend/Tests/Functional/Utility/BackendUtilityTest.php+2 −1
- typo3/sysext/backend/Tests/Functional/View/Drawing/BackendLayoutRendererTest.php+2 −1
- typo3/sysext/backend/Tests/Functional/View/PageLayoutViewTest.php+2 −1
- typo3/sysext/core/Tests/Functional/Authentication/Fixtures/be_users.xmldeleted+0 −100
- typo3/sysext/core/Tests/Functional/Authentication/Mfa/MfaProviderRegistryTest.php+2 −1
- typo3/sysext/core/Tests/Functional/Authentication/BackendUserAuthenticationTest.php+2 −6
- typo3/sysext/core/Tests/Functional/DataHandling/DataHandler/CheckboxValidationTest.php+2 −1
- typo3/sysext/core/Tests/Functional/DataHandling/DataHandler/SecurityTest.php+2 −1
- typo3/sysext/core/Tests/Functional/DataHandling/Regular/Hooks/PagesTsConfigGuardTest.php+3 −9
- typo3/sysext/core/Tests/Functional/DataHandling/AbstractDataHandlerActionTestCase.php+2 −1
- typo3/sysext/core/Tests/Functional/DataScenarios/AbstractDataHandlerActionTestCase.php+2 −1
- typo3/sysext/core/Tests/Functional/Fixtures/be_users.xmldeleted+0 −33
- typo3/sysext/core/Tests/Functional/Fixtures/be_users_admin.csvnew+4 −0
- typo3/sysext/core/Tests/Functional/Messaging/FlashMessageQueueTest.php+16 −11
- typo3/sysext/core/Tests/Functional/Resource/ResourceStorageTest.php+26 −13
- typo3/sysext/core/Tests/Functional/Resource/StorageRepositoryTest.php+2 −1
- typo3/sysext/core/Tests/Functional/Resource/SynchronizeFolderRelationsTest.php+2 −1
- typo3/sysext/core/Tests/Functional/Routing/Aspect/PersistedAliasMapperTest.php+2 −2
- typo3/sysext/core/Tests/Functional/Routing/Aspect/PersistedPatternMapperTest.php+2 −2
- typo3/sysext/core/Tests/Functional/Tca/BackendGroupsVisibleFieldsTest.php+2 −1
- typo3/sysext/core/Tests/Functional/Tca/BackendUsersVisibleFieldsTest.php+4 −2
- typo3/sysext/core/Tests/Functional/Tca/CategoryVisibleFieldsTest.php+2 −1
- typo3/sysext/core/Tests/Functional/Tca/FileCollectionVisibleFieldsTest.php+2 −1
- typo3/sysext/core/Tests/Functional/Tca/FileMetadataVisibleFieldsTest.php+2 −1
- typo3/sysext/core/Tests/Functional/Tca/FileStorageVisibleFieldsTest.php+2 −1
- typo3/sysext/core/Tests/Functional/Tca/NewsVisibleFieldsTest.php+2 −1
- typo3/sysext/core/Tests/Functional/Tca/PagesVisibleFieldsTest.php+2 −1
- typo3/sysext/core/Tests/Functional/Utility/RootlineUtilityTest.php+7 −14
- typo3/sysext/felogin/Tests/Functional/Fixtures/be_users.csvnew+4 −0
- typo3/sysext/felogin/Tests/Functional/Tca/ContentVisibleFieldsTest.php+2 −1
- typo3/sysext/filemetadata/Tests/Functional/Fixtures/be_users.csvnew+4 −0
- typo3/sysext/filemetadata/Tests/Functional/Tca/FileMetadataVisibleFieldsTest.php+2 −1
- typo3/sysext/fluid/Tests/Functional/Fixtures/be_users.csvnew+4 −0
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Link/EmailViewHelperTest.php+2 −1
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Link/FileViewHelperTest.php+2 −1
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/FlashMessagesViewHelperTest.php+2 −1
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/ImageViewHelperTest.php+2 −1
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/TranslateViewHelperTest.php+4 −2
- typo3/sysext/fluid_styled_content/Tests/Functional/Fixtures/be_users.csvnew+4 −0
- typo3/sysext/fluid_styled_content/Tests/Functional/Rendering/SecureHtmlRenderingTest.php+2 −1
- typo3/sysext/fluid_styled_content/Tests/Functional/Tca/ContentVisibleFieldsTest.php+2 −1
- typo3/sysext/form/Tests/Functional/Fixtures/be_users.csvnew+4 −0
- typo3/sysext/form/Tests/Functional/RequestHandling/AbstractRequestHandlingTest.php+2 −1
- typo3/sysext/frontend/Tests/Functional/ContentObject/ContentObjectRendererTest.php+2 −4
- typo3/sysext/frontend/Tests/Functional/ContentObject/FilesContentObjectTest.php+2 −2
- typo3/sysext/frontend/Tests/Functional/Fixtures/be_users.csvnew+4 −0
- typo3/sysext/frontend/Tests/Functional/Imaging/GifBuilderTest.php+2 −4
- typo3/sysext/frontend/Tests/Functional/Middleware/BackendUserAuthenticatorTest.php+3 −2
- typo3/sysext/frontend/Tests/Functional/SiteHandling/EnhancerLinkGenerator/AbstractEnhancerLinkGeneratorTestCase.php+9 −27
- typo3/sysext/frontend/Tests/Functional/SiteHandling/EnhancerSiteRequest/AbstractEnhancerSiteRequestTest.php+10 −40
- typo3/sysext/frontend/Tests/Functional/SiteHandling/LocalizedPageRendering/AbstractLocalizedPagesTestCase.php+3 −5
- typo3/sysext/frontend/Tests/Functional/SiteHandling/EidRequestTest.php+10 −21
- typo3/sysext/frontend/Tests/Functional/SiteHandling/MountPointTest.php+12 −64
- typo3/sysext/frontend/Tests/Functional/SiteHandling/SiteRequestTest.php+18 −106
- typo3/sysext/frontend/Tests/Functional/SiteHandling/SlugLinkGeneratorTest.php+17 −127
- typo3/sysext/frontend/Tests/Functional/SiteHandling/SlugSiteRequestTest.php+18 −120
- typo3/sysext/frontend/Tests/Functional/SiteHandling/TypoLinkGeneratorTest.php+20 −81
- typo3/sysext/frontend/Tests/Functional/Tca/BackendLayoutVisibleFieldsTest.php+2 −3
- typo3/sysext/frontend/Tests/Functional/Tca/ContentVisibleFieldsTest.php+2 −1
- typo3/sysext/frontend/Tests/Functional/Tca/FrontendGroupsVisibleFieldsTest.php+2 −3
- typo3/sysext/frontend/Tests/Functional/Tca/FrontendUsersVisibleFieldsTest.php+2 −4
- typo3/sysext/frontend/Tests/Functional/Tca/PagesLanguageOverlayVisibleFieldsTest.php+4 −16
- typo3/sysext/frontend/Tests/Functional/Tca/TemplateVisibleFieldsTest.php+2 −1
- typo3/sysext/impexp/Tests/Functional/Fixtures/DatabaseImports/be_users.csvnew+4 −0
- typo3/sysext/impexp/Tests/Functional/AbstractImportExportTestCase.php+2 −1
- typo3/sysext/linkvalidator/Tests/Functional/Repository/BrokenLinkRepositoryTest.php+2 −9
- typo3/sysext/lowlevel/Tests/Functional/Database/QueryGeneratorTest.php+2 −1
- typo3/sysext/lowlevel/Tests/Functional/Fixtures/be_users.csvnew+4 −0
- typo3/sysext/recordlist/Tests/Functional/Fixtures/be_users.csvnew+4 −0
- typo3/sysext/recordlist/Tests/Functional/RecordList/Controller/BrowseLinksControllerTest.php+2 −1
- typo3/sysext/recordlist/Tests/Functional/RecordList/DownloadRecordListTest.php+2 −1
- typo3/sysext/recycler/Tests/Functional/Fixtures/Database/be_users.csv+4 −4
- typo3/sysext/recycler/Tests/Functional/Fixtures/Database/be_users.xmldeleted+0 −43
- typo3/sysext/recycler/Tests/Functional/Recycle/Pages/AdminRecycleTest.php+3 −4
- typo3/sysext/recycler/Tests/Functional/Recycle/Pages/UserRecycleTest.php+3 −4
- typo3/sysext/recycler/Tests/Functional/Recycle/AbstractRecycleTestCase.php+0 −28
- typo3/sysext/redirects/Tests/Functional/Service/Fixtures/be_users.csvnew+4 −0
- typo3/sysext/redirects/Tests/Functional/Service/RedirectServiceTest.php+4 −2
- typo3/sysext/redirects/Tests/Functional/Service/SlugServiceTest.php+2 −1
- typo3/sysext/scheduler/Tests/Functional/Fixtures/be_users.csvnew+4 −0
- typo3/sysext/scheduler/Tests/Functional/Tca/TaskGroupVisibleFieldsTest.php+2 −1
- typo3/sysext/seo/Tests/Functional/Fixtures/be_users.csvnew+4 −0
- typo3/sysext/seo/Tests/Functional/HrefLang/HrefLangGeneratorTest.php+2 −1
- typo3/sysext/sys_note/Tests/Functional/Fixtures/be_users.csvnew+4 −0
- typo3/sysext/sys_note/Tests/Functional/Tca/NoteVisibleFieldsTest.php+2 −1
- typo3/sysext/workspaces/Tests/Functional/Fixtures/be_users.csvnew+4 −0
- typo3/sysext/workspaces/Tests/Functional/Hook/DataHandlerHookTest.php+2 −1
- typo3/sysext/workspaces/Tests/Functional/Service/WorkspaceServiceTest.php+2 −1
- typo3/sysext/workspaces/Tests/Functional/Tca/WorkspaceStageVisibleFieldsTest.php+2 −1
- typo3/sysext/workspaces/Tests/Functional/Tca/WorkspaceVisibleFieldsTest.php+2 −1
- composer.lock+4 −4
Review log 1016
-
Christian Kuhn uploaded patch set 1 07/13/22, 17:10
-
core-ci voted on patch set 1 V -1 07/13/22, 17:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29079
-
Christian Kuhn uploaded patch set 2 07/13/22, 17:39
-
core-ci voted on patch set 2 V -1 07/13/22, 17:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29080
-
Christian Kuhn uploaded patch set 3 07/13/22, 18:20
-
core-ci voted on patch set 3 V -1 07/13/22, 18:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29084
-
Christian Kuhn uploaded patch set 4 07/13/22, 19:03
-
core-ci voted on patch set 4 V -1 07/13/22, 19:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29087
-
Christian Kuhn uploaded patch set 5 07/13/22, 19:13
-
core-ci voted on patch set 5 V +1 07/13/22, 19:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29090
-
Christian Kuhn uploaded patch set 6 07/13/22, 19:35
-
Benni Mack voted on patch set 6 V +1 CR +1 07/13/22, 19:36
-
core-ci voted on patch set 6 V +1 07/13/22, 19:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29096
-
Stefan Bürk voted on patch set 6 V +1 CR +1 07/13/22, 19:58
-
Stefan Bürk voted on patch set 6 V +2 CR +2 07/13/22, 19:58
-
Stefan Bürk merged patch set 7 07/13/22, 19:58