Review main Merged

75168[TASK] Avoid setUpBackendUserFromFixture() in functionals

Christian Kuhn CR +2 V +2 Expert +414 −995 updated 07/13/22, 19:58

Commit message

The testing-framework method setUpBackendUserFromFixture()
is kinda flawed since it does two things at once: It
creates db records and creates global state. This is
unfortunate in various cases, especially when  db
snapshoting is used. Additionally, it relies on a
class property which defaults to a fixture file
delivered by testing-framework in XML format. We
want to get rid of the .xml fixtures, and we don't
want that the testing-framework delivers default
fixtures.

The patch adapts all usages of the property and
of method setUpBackendUserFromFixture() by splitting
it into two calls to first insert a local extension
fixture .csv file and to then call the backend user
init helper method.

This finishes the removal of .xml fixture uses
in the core.

$ composer req --dev typo3/testing-framework:dev-main

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Benni Mack +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 111

Show 91 more files

Review log 1016

  1. Christian Kuhn uploaded patch set 1 07/13/22, 17:10

  2. core-ci voted on patch set 1 V -1 07/13/22, 17:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29079

  3. Christian Kuhn uploaded patch set 2 07/13/22, 17:39

  4. core-ci voted on patch set 2 V -1 07/13/22, 17:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29080

  5. Christian Kuhn uploaded patch set 3 07/13/22, 18:20

  6. core-ci voted on patch set 3 V -1 07/13/22, 18:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29084

  7. Christian Kuhn uploaded patch set 4 07/13/22, 19:03

  8. core-ci voted on patch set 4 V -1 07/13/22, 19:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29087

  9. Christian Kuhn uploaded patch set 5 07/13/22, 19:13

  10. core-ci voted on patch set 5 V +1 07/13/22, 19:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29090

  11. Christian Kuhn uploaded patch set 6 07/13/22, 19:35

  12. Benni Mack voted on patch set 6 V +1 CR +1 07/13/22, 19:36

  13. core-ci voted on patch set 6 V +1 07/13/22, 19:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29096

  14. Stefan Bürk voted on patch set 6 V +1 CR +1 07/13/22, 19:58

  15. Stefan Bürk voted on patch set 6 V +2 CR +2 07/13/22, 19:58

  16. Stefan Bürk merged patch set 7 07/13/22, 19:58