Review main Merged

75171[TASK] Avoid unnecessary database snapshot in two test-cases

Stefan Bürk CR +2 V +2 Easy +7 −15 updated 07/14/22, 07:18

Commit message

Two functional tests use the testing-framework db snapshot
feature without really needing it. Those can be simplified.

This patch removes the `withDatabaseSnapshot()` usage, and
cleans one test which fails to free an only partially
fetched db result set, which otherwise leads to fails with
sqlite.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1117

  1. Stefan Bürk uploaded patch set 1 07/14/22, 05:25

  2. core-ci voted on patch set 1 V +1 07/14/22, 05:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29108

  3. Stefan Bürk updated the commit message in patch set 2 07/14/22, 05:35

  4. Stefan Bürk uploaded patch set 3 07/14/22, 05:39

  5. core-ci voted on patch set 2 V +1 07/14/22, 05:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29109

  6. core-ci voted on patch set 3 V +1 07/14/22, 05:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29110

  7. Andreas Kienast updated the commit message in patch set 4 07/14/22, 06:28

  8. Andreas Kienast voted on patch set 4 V +1 CR +1 07/14/22, 06:29

  9. Christian Kuhn updated the commit message in patch set 5 07/14/22, 06:29

  10. Christian Kuhn voted on patch set 5 V +1 CR +1 07/14/22, 06:29

  11. core-ci voted on patch set 4 V +1 07/14/22, 06:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29115

  12. core-ci voted on patch set 5 V +1 07/14/22, 06:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29116

  13. Andreas Kienast updated the commit message in patch set 6 07/14/22, 06:45

  14. Andreas Kienast commented on patch set 6 V +1 CR +1 07/14/22, 06:46

    Sorry ¯\_(ツ)_/¯
  15. core-ci voted on patch set 6 V +1 07/14/22, 06:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29118

  16. Christian Kuhn commented on patch set 6 V +2 CR +2 07/14/22, 07:18

    thx!
  17. Christian Kuhn merged patch set 7 07/14/22, 07:18