Review main Merged

75174[TASK] Streamline functional test snapshots

Christian Kuhn CR +2 V +2 Normal +76 −110 updated 07/14/22, 09:15

Commit message

The testing-framework functional test db snapshot
helper expects the database to be empty when
withDatabaseSnapshot() is called. Rows should
only be populated within the create callback.

There was a workaround in testing-framework to
relax this restriction due to unfortunate backend
user related setup code flow. This has been resolved
with #97928, so the testing-framework snapshot can
be more strict on this now.

The patch adapts a couple of snapshot usages to
align to this enforced restriction.

$ composer req --dev typo3/testing-framework:dev-main

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 8

Review log 711

  1. Christian Kuhn uploaded patch set 1 07/14/22, 07:51

  2. core-ci voted on patch set 1 V -1 07/14/22, 08:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29121

  3. Christian Kuhn uploaded patch set 2 07/14/22, 08:24

  4. core-ci voted on patch set 2 V +1 07/14/22, 08:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29124

  5. Christian Kuhn uploaded patch set 3 07/14/22, 08:51

  6. core-ci voted on patch set 3 V +1 07/14/22, 08:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29125

  7. Christian Kuhn uploaded patch set 4 07/14/22, 09:03

  8. core-ci voted on patch set 4 V +1 07/14/22, 09:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29127

  9. Stefan Bürk voted on patch set 4 V +1 CR +1 07/14/22, 09:14

  10. Christian Kuhn commented on patch set 4 V +2 CR +2 07/14/22, 09:15

    I'll take the freedom to merge this rather quickly: A functional test merge for this patch otherwise leads to fails in next nightly when this is not in.
  11. Christian Kuhn merged patch set 5 07/14/22, 09:15