75175[BUGFIX] Disable asset concatenation/compression in backend
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Markus Klein +1
-
Verified V +2 Done
- Benni Mack +2
- Markus Klein +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1418
-
Thomas Maroschik uploaded patch set 1 07/14/22, 09:49
-
core-ci voted on patch set 1 V +1 07/14/22, 09:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29129
-
Oliver Klee updated the commit message in patch set 2 07/14/22, 10:12
-
Oliver Klee updated the commit message in patch set 3 07/14/22, 10:13
-
Oliver Klee voted on patch set 3 CR +1 07/14/22, 10:13
-
core-ci voted on patch set 2 V +1 07/14/22, 10:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29130
-
core-ci voted on patch set 3 V +1 07/14/22, 10:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29131
-
Markus Klein commented on patch set 3 V +1 CR +1 07/14/22, 20:02
I generally agree with this change. CSS processing ("uglify",minification) should be pretty obsolete when any kind of compression (gzip, brotli) is active. If still deemed necessary, this can/should be done with some build-step. What is lost with this change is the possibility to compress the assets statically (the famous .js.gzip files), which would save some CPU cycles by the webserver, which would need to do this on demand. For the future we could think of a resurrection of some feature-parts, but with better implementation: * compression independent of minification * "deterministic" file naming, based on source file's content hash instead of mtime and size. -
Stefan Bürk commented on patch set 3 07/14/22, 23:14
Maybe I'm wrong, but if you are in need to switch this, you could implement in your instance/sitepackage or a shareable extension following hook: ``` $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['t3lib/class.t3lib_pagerenderer.php']['render-preProcess'] ... ``` execute the disable methods for the pagerenderer there ? Even http2/3 is out there, there are a lot of providers not providing it (out of the box) or upgrading older accounts etc - and this would be a decrease there. However - I would not call this a bug and a hook can be used to change this. At least, as the hook exists and it is not a bug, I would say 10.4 is out of the scope of being a "security or priority bugfix". -
Benni Mack commented on patch set 3 07/28/22, 12:19
I think this one also fixes https://forge.typo3.org/issues/95848 -
Benni Mack updated the commit message in patch set 4 08/06/22, 14:06
-
Benni Mack commented on patch set 4 08/06/22, 14:07
The interesting part (while I was talking to Helmut the past days) is why the feature was introduced in the first place: during v4 development, we had too many CSS files and IE did not support the amount of CSS files we included, so we had to be creative. This is why we did the concatenation. I also agree we do not need to worry about this at all in TYPO3 Backend anymore, and will also remove the support in ResourceCompressor for BE for v12. -
Benni Mack voted on patch set 4 V +1 CR +1 08/06/22, 14:07
-
Benni Mack commented on patch set 4 08/06/22, 14:07
Reply
Done -
core-ci voted on patch set 4 V +1 08/06/22, 14:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29895
-
Markus Klein voted on patch set 4 V +1 CR +1 08/08/22, 07:59
-
Benni Mack voted on patch set 4 V +2 CR +2 08/08/22, 08:03
-
Benni Mack merged patch set 5 08/08/22, 08:03