Review main Merged

75179[BUGFIX] Skip resolving backpath for already absolute paths

Oli Bartsch CR +2 V +2 Easy +23 −1 updated 07/14/22, 13:56

Commit message

In case GU::createVersionNumberedFilename() receives
a file with an absolute path, no back path should be resolved
since the resolved path will always be invalid, which led
to no version number got added to the filename anymore.

This is now fixed by checking for the path being absolute.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Oliver Klee +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Nikita Hovratov +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 911

  1. Oli Bartsch uploaded patch set 1 07/14/22, 12:56

  2. core-ci voted on patch set 1 V +1 07/14/22, 13:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29146

  3. Andreas Kienast voted on patch set 1 V +1 CR +1 07/14/22, 13:07

  4. Jochen Roth voted on patch set 1 V +1 CR +1 07/14/22, 13:07

  5. Oliver Klee commented on patch set 2 07/14/22, 13:23

    Published edit on patch set 1.
  6. Oliver Klee voted on patch set 2 CR +1 07/14/22, 13:23

  7. core-ci voted on patch set 2 V +1 07/14/22, 13:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29147

  8. Benni Mack voted on patch set 2 V +1 CR +1 07/14/22, 13:32

  9. Nikita Hovratov voted on patch set 2 V +1 07/14/22, 13:33

  10. Oli Bartsch voted on patch set 2 V +2 CR +2 07/14/22, 13:56

  11. Oli Bartsch merged patch set 3 07/14/22, 13:56