Review main Abandoned

75183[WIP][FEATURE] Add dropdown multiselect

Jochen Roth CR 0 V 0 Hard +621 −0 updated 09/09/24, 12:50

Commit message

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 6

Review log 1218

  1. Jochen Roth uploaded patch set 1 07/14/22, 18:49

  2. Jochen Roth marked it work in progress 07/14/22, 18:50

  3. Oliver Klee commented on patch set 1 07/14/22, 18:51

    Can this also be used with the keyboard, or will this break accessibility for the dropdown?
  4. core-ci voted on patch set 1 V -1 07/14/22, 18:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29164

  5. Jochen Roth uploaded patch set 2 07/14/22, 18:58

  6. core-ci voted on patch set 2 V -1 07/14/22, 19:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29165

  7. Jochen Roth uploaded patch set 3 07/14/22, 19:23

  8. core-ci voted on patch set 3 V -1 07/14/22, 19:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29167

  9. Mathias Brodala commented on patch set 3 07/15/22, 07:03

    Unresolved

    I'd avoid the term "dropdown": 1. It's not important ("multi selection" is) 2. It can also be a dropup, dropleft, dropright depending on the layout and space 3. There is no such term in TCA yet, not even with "selectSingle"
  10. Oli Bartsch commented on patch set 3 07/15/22, 07:27

    Folks, please.. This patch is marked as WIP, both in the commit message and in Gerrit. What about letting Jochen finish his work and review the patch as soon as it is "Ready to review"?
  11. Mathias Brodala commented on patch set 3 07/15/22, 07:31

    Reply

    Sure, no one demanded that everything that was noted must be done or done immediately.
  12. Jochen Roth uploaded patch set 4 07/15/22, 19:08

  13. core-ci voted on patch set 4 V -1 07/15/22, 19:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29235

  14. Jochen Roth uploaded patch set 5 V -1 01/02/23, 00:36

  15. core-ci voted on patch set 5 V -1 01/02/23, 00:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35417

  16. Jochen Roth uploaded patch set 6 V -1 01/03/23, 02:04

  17. core-ci voted on patch set 6 V -1 01/03/23, 02:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35429

  18. Jochen Roth abandoned the change 09/09/24, 12:50