75184[!!!][FEATURE] Add PSR-14 AfterPageTreeItemsPreparedEvent
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Benni Mack +2
- Jochen Roth +1
-
Verified V +2 Done
- Oli Bartsch +2
- Benni Mack +2
- Jochen Roth +1
- core-ci +1 CI
Issues 1
Files 12
- typo3/sysext/backend/Classes/Controller/Event/AfterPageTreeItemsPreparedEvent.phpnew+51 −0
- typo3/sysext/backend/Classes/Controller/Page/TreeController.php+18 −47
- typo3/sysext/backend/Tests/Functional/Controller/Page/TreeControllerTest.php+37 −0
- typo3/sysext/backend/Tests/Unit/Controller/Event/AfterPageTreeItemsPreparedEventTest.phpnew+53 −0
- typo3/sysext/core/Documentation/Changelog/12.0/Breaking-97945-RemovedWorkspaceServiceHooks.rstnew+40 −0
- typo3/sysext/core/Documentation/Changelog/12.0/Feature-97945-PSR14AfterPageTreeItemsPreparedEvent.rstnew+64 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/ArrayDimensionMatcher.php+12 −0
- typo3/sysext/workspaces/Classes/EventListener/PageTreeItemsHighlighter.phpnew+75 −0
- typo3/sysext/workspaces/Classes/Service/WorkspaceService.php+0 −18
- typo3/sysext/workspaces/Configuration/Services.yaml+5 −0
- typo3/sysext/workspaces/Tests/Functional/EventListener/PageTreeItemsHighlighterTest.phpnew+152 −0
- typo3/sysext/workspaces/Tests/Functional/Fixtures/tt_content.csvnew+4 −0
Review log 1722
-
Oli Bartsch uploaded patch set 1 07/14/22, 19:39
-
core-ci voted on patch set 1 V +1 07/14/22, 19:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29168
-
Oliver Klee commented on patch set 1 07/14/22, 20:11
Please let's have tests that the hooks get called, and simple tests that the getters/setters of the hook work fine. We can steal from this change for this: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74825 -
Oliver Klee commented on patch set 1 CR -1 07/14/22, 20:14
ModifyPagesWithVersionsInTableEvent.php:31Typo (also in the getter, and also in the other event class): worksapceId -> workspaceId -
Oli Bartsch uploaded patch set 2 07/15/22, 09:36
-
Oli Bartsch commented on patch set 2 07/15/22, 09:40
Reply
DoneModifyPagesWithVersionsInTableEvent.php:31ReplyDone -
core-ci voted on patch set 2 V +1 07/15/22, 09:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29198
-
Andreas Kienast commented on patch set 2 CR -1 07/15/22, 09:44
on it -
Andreas Kienast uploaded patch set 3 07/15/22, 09:53
-
Andreas Kienast voted on patch set 3 V +1 CR +1 07/15/22, 09:54
-
core-ci voted on patch set 3 V +1 07/15/22, 10:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29199
-
Benni Mack commented on patch set 3 07/15/22, 10:03
ModifyVersionsOnPageEvent.php:23I think this event name is really misleading. -
Benni Mack voted on patch set 3 CR -1 07/15/22, 10:03
-
Oli Bartsch uploaded patch set 4 07/15/22, 19:55
-
core-ci voted on patch set 4 V -1 07/15/22, 20:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29238
-
Oli Bartsch uploaded patch set 5 07/15/22, 20:14
-
core-ci voted on patch set 5 V +1 07/15/22, 20:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29241
-
Oli Bartsch commented on patch set 5 07/15/22, 20:30
ModifyVersionsOnPageEvent.php:23ReplyDone -
Jochen Roth voted on patch set 5 V +1 CR +1 07/15/22, 21:05
-
Benni Mack voted on patch set 5 V +2 CR +2 07/15/22, 21:31
-
Oli Bartsch voted on patch set 5 V +2 CR +2 07/15/22, 21:34
-
Oli Bartsch merged patch set 6 07/15/22, 21:34