75188[!!!][FEATURE] Replace $GLOBALS['PAGES_TYPES'] with shared state object
Commit message
Review
-
Code review CR +2 Done
- Oliver Hader +2
- Georg Ringer +1
- Kevin Appelt +1
-
Verified V +2 Done
- Oliver Hader +2
- Georg Ringer +1
- core-ci +1 CI
Issues 1
Files 62
- Build/phpstan/phpstan-baseline.neon+0 −5
- typo3/sysext/backend/Classes/Controller/Page/NewMultiplePagesController.php+2 −3
- typo3/sysext/backend/Classes/Controller/NewRecordController.php+3 −4
- typo3/sysext/core/Classes/Core/Bootstrap.php+0 −1
- typo3/sysext/core/Classes/DataHandling/DataHandler.php+15 −22
- typo3/sysext/core/Classes/DataHandling/PageDoktypeRegistry.php8new+131 −0
- typo3/sysext/core/Classes/Utility/ExtensionManagementUtility.php3+20 −2
- typo3/sysext/core/Documentation/Changelog/12.0/Breaking-98487-GLOBALSPAGES_TYPESRemoved.rst3new+38 −0
- typo3/sysext/core/Documentation/Changelog/12.0/Deprecation-98487-ExtensionManagementUtilityallowTableOnStandardPages.rstnew+40 −0
- typo3/sysext/core/Documentation/Changelog/12.0/Feature-98487-TCAOptionCtrlsecurityignorePageTypeRestriction.rstnew+32 −0
- typo3/sysext/core/Tests/Acceptance/Application/ConfigurationModule/ConfigurationModuleProviderCest.php+1 −1
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_datahandler/Configuration/TCA/tx_testdatahandler_element.php+3 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_datahandler/ext_tables.phpdeleted+0 −9
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_flex_section_container/Configuration/TCA/tx_testflexsectioncontainer.php+3 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_flex_section_container/ext_tables.phpdeleted+0 −9
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_irre_csv/Configuration/TCA/tx_testirrecsv_hotel.php+3 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_irre_csv/Configuration/TCA/tx_testirrecsv_offer.php+3 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_irre_csv/Configuration/TCA/tx_testirrecsv_price.php+3 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_irre_csv/ext_tables.phpdeleted+0 −11
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_irre_foreignfield/Configuration/TCA/tx_testirreforeignfield_hotel.php+3 −0
Show 42 more files
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_irre_foreignfield/Configuration/TCA/tx_testirreforeignfield_offer.php+3 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_irre_foreignfield/Configuration/TCA/tx_testirreforeignfield_price.php+3 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_irre_foreignfield/ext_tables.phpdeleted+0 −11
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_irre_foreignfield_non_ws/Configuration/TCA/tx_testirreforeignfieldnonws_hotel.php+3 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_irre_foreignfield_non_ws/Configuration/TCA/tx_testirreforeignfieldnonws_offer.php+3 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_irre_foreignfield_non_ws/Configuration/TCA/tx_testirreforeignfieldnonws_price.php+4 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_irre_foreignfield_non_ws/ext_tables.phpdeleted+0 −11
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_irre_mm/Configuration/TCA/tx_testirremm_hotel.php+3 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_irre_mm/Configuration/TCA/tx_testirremm_offer.php+3 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_irre_mm/Configuration/TCA/tx_testirremm_price.php+3 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_irre_mm/ext_tables.phpdeleted+0 −11
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_irre_mnattributeinline/Configuration/TCA/tx_testirremnattributeinline_hotel.php+3 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_irre_mnattributeinline/Configuration/TCA/tx_testirremnattributeinline_hotel_offer_rel.php+3 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_irre_mnattributeinline/Configuration/TCA/tx_testirremnattributeinline_offer.php+3 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_irre_mnattributeinline/Configuration/TCA/tx_testirremnattributeinline_price.php+3 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_irre_mnattributeinline/ext_tables.phpdeleted+0 −11
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_irre_mnattributesimple/Configuration/TCA/tx_testirremnattributesimple_hotel.php+3 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_irre_mnattributesimple/Configuration/TCA/tx_testirremnattributesimple_hotel_offer_rel.php+3 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_irre_mnattributesimple/Configuration/TCA/tx_testirremnattributesimple_offer.php+3 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_irre_mnattributesimple/ext_tables.phpdeleted+0 −11
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_irre_mnsymmetric/Configuration/TCA/tx_testirremnsymmetric_hotel.php+3 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_irre_mnsymmetric/Configuration/TCA/tx_testirremnsymmetric_hotel_rel.php+3 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_irre_mnsymmetric/ext_tables.phpdeleted+0 −11
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_select_flex_mm/Configuration/TCA/tx_testselectflexmm_foreign.php+3 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_select_flex_mm/Configuration/TCA/tx_testselectflexmm_local.php+3 −1
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_select_flex_mm/ext_tables.phpdeleted+0 −10
- typo3/sysext/core/ext_tables.php+0 −28
- typo3/sysext/frontend/Configuration/TCA/backend_layout.php+3 −0
- typo3/sysext/frontend/Configuration/TCA/sys_template.php+3 −0
- typo3/sysext/frontend/Configuration/TCA/tt_content.php+3 −0
- typo3/sysext/frontend/ext_tables.phpdeleted+0 −10
- typo3/sysext/impexp/Classes/ImportExport.php+2 −6
- typo3/sysext/indexed_search/Configuration/TCA/index_config.php+3 −0
- typo3/sysext/indexed_search/ext_tables.phpdeleted+0 −9
- typo3/sysext/install/Configuration/ExtensionScanner/Php/ArrayGlobalMatcher.php+7 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodCallStaticMatcher.php+9 −0
- typo3/sysext/lowlevel/Classes/ConfigurationModuleProvider/PageDoktypeProvider.phpnew+56 −0
- typo3/sysext/lowlevel/Configuration/Services.yaml+1 −2
- typo3/sysext/lowlevel/Documentation/BackendModules/Configuration.rst+1 −1
- typo3/sysext/lowlevel/Resources/Private/Language/locallang.xlf+1 −1
- typo3/sysext/sys_note/Configuration/TCA/sys_note.php+3 −0
- typo3/sysext/sys_note/ext_tables.phpdeleted+0 −9
Review log 2941
Show 916 earlier messages
-
Benni Mack uploaded patch set 1 07/15/22, 08:50
-
core-ci voted on patch set 1 V -1 07/15/22, 08:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29190
-
Simon Schaufelberger commented on patch set 1 09/24/22, 23:11
can this make it into v12? -
Benni Mack uploaded patch set 2 09/30/22, 20:09
-
core-ci voted on patch set 2 V -1 09/30/22, 20:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31768
-
Benni Mack uploaded patch set 3 09/30/22, 21:05
-
Benni Mack uploaded patch set 4 09/30/22, 21:13
-
core-ci voted on patch set 3 V +1 09/30/22, 21:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31773
-
core-ci voted on patch set 4 V -1 09/30/22, 21:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31774
-
Benni Mack uploaded patch set 5 09/30/22, 21:22
-
Benni Mack uploaded patch set 6 09/30/22, 21:23
-
core-ci voted on patch set 5 V +1 09/30/22, 21:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31776
-
core-ci voted on patch set 6 V +1 09/30/22, 21:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31777
-
Benni Mack uploaded patch set 7 09/30/22, 22:12
-
Benni Mack commented on patch set 7 09/30/22, 22:13
Reply
Ready now. -
core-ci voted on patch set 7 V +1 09/30/22, 22:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31779
-
Benni Mack commented on patch set 7 09/30/22, 22:21
Reply
Done -
Chris Müller commented on patch set 7 10/01/22, 06:32
Breaking-98487-GLOBALSPAGES_TYPESRemoved.rst:34Before, a new page type is registered in ext_tables.php like this: $GLOBALS['PAGES_TYPES'][116] = [ 'type' => 'web', 'allowedTables' => '*', ]; The new way will be: $pageDoktypeRegistry = GeneralUtility::makeInstance(PageDoktypeRegistry); $pageDoktypeRegistry->add(116, [ 'type' => 'web', 'allowedTables' => '*', ]); Should this also be placed in ext_tables.php? And can we add the example to this RST? -
Georg Ringer voted on patch set 7 V +1 CR +1 10/01/22, 20:23
-
Benni Mack commented on patch set 7 10/01/22, 21:34
Breaking-98487-GLOBALSPAGES_TYPESRemoved.rst:34ReplyI think we could add this separately into TCA[pages][types] - at least that would be my wish. However, this is not 100% finalized yet, so the official "best practice" would be something to be documented later-on (probably 12.1). I hope this is OK if we provide extensive documentation about this at a later stage. This way we can avoid documenting something that we might need to change in further 12.x releases. -
Markus Klein commented on patch set 7 10/02/22, 00:09
PageDoktypeRegistry.php:75same syntax as in line 87 can be used, right?PageDoktypeRegistry.php:89should we really keep this string-based (CSV)? Or could we go with arrays now? -
Chris Müller commented on patch set 7 10/02/22, 05:53
Breaking-98487-GLOBALSPAGES_TYPESRemoved.rst:34ReplyAck -
Benni Mack commented on patch set 7 10/02/22, 07:58
PageDoktypeRegistry.php:89Replythe good thing is we can change the underlying API now without being breaking anymore then :) -
Benni Mack commented on patch set 8 10/02/22, 07:59
Published edit on patch set 7. -
Benni Mack commented on patch set 8 10/02/22, 07:59
PageDoktypeRegistry.php:75ReplyDonePageDoktypeRegistry.php:89ReplyDone -
core-ci voted on patch set 8 V +1 10/02/22, 08:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31859
-
Benni Mack uploaded patch set 9 10/02/22, 10:48
-
core-ci voted on patch set 9 V -1 10/02/22, 11:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31869
-
Benni Mack uploaded patch set 10 10/02/22, 11:15
-
core-ci voted on patch set 10 V -1 10/02/22, 11:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31870
-
Benni Mack uploaded patch set 11 10/02/22, 11:31
-
core-ci voted on patch set 11 V +1 10/02/22, 11:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31871
-
Kevin Appelt commented on patch set 11 10/02/22, 11:49
PageDoktypeRegistry.php:51If I do understand it right, this should be "against a fallback", right? Or something like "against default values as fallback".ExtensionManagementUtility.php:724Is there a reason for checking for this call with an empty string and not telling the user about it? For me it seems like a misconfiguration and it should throw an exception. -
Benni Mack uploaded patch set 12 10/02/22, 12:08
-
Benni Mack commented on patch set 11 10/02/22, 12:09
PageDoktypeRegistry.php:51Replyadapted the comment.ExtensionManagementUtility.php:724ReplyYes. Previously, this was added to the global array as a concat string (= doing nothing), if we now add the table (which could be a list of tables with comma-separated) as well, there is no benefit of doing so. Through an exception does not harm, but is also not needed, as the method is not needed anymore (see RST). -
core-ci voted on patch set 12 V +1 10/02/22, 12:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31872
-
Kevin Appelt commented on patch set 12 CR +1 10/02/22, 13:26
ExtensionManagementUtility.php:724ReplyAck -
Oliver Hader commented on patch set 12 CR +1 10/02/22, 17:29
PageDoktypeRegistry.php:78UnresolvedIt a bit ugly (really, just a little bit) - null, int, string and mixed array-keys. Anyway, since it's encapsulated internally, fine... -
Georg Ringer voted on patch set 12 V +1 CR +1 10/02/22, 17:38
-
Oliver Hader voted on patch set 12 V +2 CR +2 10/02/22, 17:40
-
Oliver Hader merged patch set 13 10/02/22, 17:40