Review 11.5 Merged

75192[BUGFIX] Allow changing FF sections in new version overlays

Christian Kuhn CR +2 V +2 Easy +25 −2 updated 07/15/22, 14:32

Commit message

Creating a version overlay of a record that has flexform
sections and moving or deleting some of these sections
at the same time fails in DataHandler due to a wrong uid
lookup for the section command array.

The patch fixes this scenario in the DataHandler flexform
processing code and leaves an according explanation comment.

Note this v11 backport contains the fix only and skips
the functional tests that have been added with main.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 68

  1. Christian Kuhn uploaded patch set 1 07/15/22, 14:06

  2. Benni Mack commented on patch set 1 07/15/22, 14:08

    I think this would be noteworthy to also backport to v10
  3. Benni Mack updated the commit message in patch set 2 07/15/22, 14:08

  4. core-ci voted on patch set 2 V +1 07/15/22, 14:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29217

  5. Christian Kuhn voted on patch set 2 V +2 CR +2 07/15/22, 14:22

  6. Christian Kuhn merged patch set 3 07/15/22, 14:22

  7. Christian Kuhn commented on patch set 3 07/15/22, 14:24

    alright. will add the 10.4 backport.
  8. core-ci voted on patch set 1 V +1 07/15/22, 14:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29216