Review main Merged

75194[BUGFIX] Do not lose Context in AbstractContentObject

Benni Mack CR +2 V +2 Easy +8 −4 updated 07/15/22, 15:19

Commit message

When AbstractContentObject is fetching ->getPageRepository()
but TSFE hasn't been fully initialized yet, the Context
from TSFE should be used, and not the global one.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Rafael Kähm +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benni Mack +2
    • Rafael Kähm +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 912

  1. Benni Mack uploaded patch set 1 07/15/22, 14:18

  2. Rafael Kähm voted on patch set 1 V +1 CR +1 07/15/22, 14:20

  3. Benni Mack updated the commit message in patch set 2 07/15/22, 14:22

  4. Rafael Kähm commented on patch set 2 V +1 CR +1 07/15/22, 14:23

    Commit is perfect now
  5. Oliver Klee updated the commit message in patch set 3 07/15/22, 14:30

  6. core-ci voted on patch set 2 V +1 07/15/22, 14:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29222

  7. Andreas Kienast voted on patch set 3 V +1 CR +1 07/15/22, 14:32

  8. Rafael Kähm voted on patch set 3 V +1 CR +1 07/15/22, 14:33

  9. core-ci voted on patch set 3 V +1 07/15/22, 14:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29226

  10. core-ci voted on patch set 1 V +1 07/15/22, 14:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29220

  11. Benni Mack voted on patch set 3 V +2 CR +2 07/15/22, 15:19

  12. Benni Mack merged patch set 4 07/15/22, 15:19