Review main Merged

75196[BUGFIX] Fix notices in GraphicalFunctions

Georg Ringer CR +2 V +2 Easy +2 −2 updated 07/15/22, 20:13

Commit message

The provided width and height must be cast to a string to avoid
notices.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Oliver Klee +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 810

  1. Georg Ringer uploaded patch set 1 07/15/22, 19:18

  2. Georg Ringer commented on patch set 1 07/15/22, 19:18

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 07/15/22, 19:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29236

  4. Oliver Klee updated the commit message in patch set 2 07/15/22, 19:34

  5. Oliver Klee voted on patch set 2 CR +1 07/15/22, 19:34

  6. core-ci voted on patch set 2 V +1 07/15/22, 19:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29237

  7. Oli Bartsch voted on patch set 2 V +1 CR +1 07/15/22, 20:06

  8. Jochen Roth voted on patch set 2 V +1 CR +1 07/15/22, 20:12

  9. Oli Bartsch voted on patch set 2 V +2 CR +2 07/15/22, 20:13

  10. Oli Bartsch merged patch set 3 07/15/22, 20:13