Review main Merged

75203[TASK] Also run nightly PHPStan builds with highest dependencies

Oliver Klee CR +2 V +2 Easy +14 −1 updated 07/16/22, 21:15

Commit message

This allows us to see whether a new PHPStan version causes any baseline
changes, or whether an update of any other dependency brings some
interface changes that affect our type checks.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1724

  1. Oliver Klee uploaded patch set 1 07/16/22, 07:30

  2. Oliver Klee uploaded patch set 2 07/16/22, 07:32

  3. Oliver Klee commented on patch set 2 07/16/22, 07:34

    Tease: Yes, some of the dependencies come with relevant API changes. :-)
  4. Oliver Klee uploaded patch set 3 07/16/22, 07:36

  5. core-ci voted on patch set 1 V +1 07/16/22, 07:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29258

  6. core-ci voted on patch set 2 V -1 07/16/22, 07:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29259

  7. core-ci voted on patch set 3 V -1 07/16/22, 07:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29260

  8. Oliver Klee uploaded patch set 4 07/16/22, 07:49

  9. core-ci voted on patch set 4 V +1 07/16/22, 07:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29261

  10. Christian Kuhn commented on patch set 4 07/16/22, 10:56

    integrity.yml:96

    key: main-composer-max
  11. Christian Kuhn commented on patch set 4 07/16/22, 10:59

    integrity.yml:96 Reply

    scratch that. current key is fine.
  12. Christian Kuhn commented on patch set 4 07/16/22, 11:11

    running nightly on this once to be sure.
  13. Stefan Bürk voted on patch set 4 V +1 CR +1 07/16/22, 11:11

  14. Christian Kuhn commented on patch set 4 07/16/22, 11:32

    note: this is a test-ballon: it will notify via nightly in case phpstan raised something that need attention on our side. we'll see if this works out. in case it creates hassle too often, we'll scratch it again. for *this* patch, nightly will actually go red, so we'll have to resolve this with at least another patch set before.
  15. core-ci voted on patch set 4 V -1 07/16/22, 11:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29269

  16. Oliver Klee commented on patch set 4 07/16/22, 11:43

    Reply

    This change will update the Doctrine packages and fix the Doctrine-related warnings: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75204 I'll take care of creating a fix for the removed warning in ArrayUtility. (I'll still need to find out what the cause is. Maybe a fix in PHPStan, maybe something else.)
  17. Oliver Klee commented on patch set 4 07/16/22, 12:18

    … and this is the fix for the other new issue: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75208
  18. Stefan Bürk rebased onto patch set 5 07/16/22, 20:42

  19. core-ci voted on patch set 5 V +1 07/16/22, 21:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29302

  20. core-ci commented on patch set 5 07/16/22, 21:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29303

  21. Christian Kuhn voted on patch set 5 V +1 CR +1 07/16/22, 21:14

  22. Stefan Bürk voted on patch set 5 V +1 CR +1 07/16/22, 21:14

  23. Stefan Bürk voted on patch set 5 V +2 CR +2 07/16/22, 21:15

  24. Stefan Bürk merged patch set 6 07/16/22, 21:15