75205[TASK] Avoid misusing element browser for link handler concerns
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- Andreas Kienast +1
-
Verified V +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- Andreas Kienast +1
- core-ci +1 CI
Issues 4
Files 15
- typo3/sysext/recordlist/Classes/Browser/AbstractElementBrowser.php+1 −1
- typo3/sysext/recordlist/Classes/Browser/DatabaseBrowser.php+1 −1
- typo3/sysext/recordlist/Classes/Browser/ElementBrowserInterface.php11+7 −0
- typo3/sysext/recordlist/Classes/Browser/FolderBrowser.php+1 −1
- typo3/sysext/recordlist/Classes/Browser/RecordBrowser.phpdeleted+0 −78
- typo3/sysext/recordlist/Classes/LinkHandler/AbstractLinkHandler.php+1 −11
- typo3/sysext/recordlist/Classes/LinkHandler/FileLinkHandler.php+2 −1
- typo3/sysext/recordlist/Classes/LinkHandler/FolderLinkHandler.php+2 −1
- typo3/sysext/recordlist/Classes/LinkHandler/LinkHandlerInterface.php+13 −2
- typo3/sysext/recordlist/Classes/LinkHandler/MailLinkHandler.php+2 −1
- typo3/sysext/recordlist/Classes/LinkHandler/PageLinkHandler.php+2 −1
- typo3/sysext/recordlist/Classes/LinkHandler/RecordLinkHandler.php+108 −41
- typo3/sysext/recordlist/Classes/LinkHandler/TelephoneLinkHandler.php+2 −1
- typo3/sysext/recordlist/Classes/LinkHandler/UrlLinkHandler.php+2 −1
- typo3/sysext/recordlist/Configuration/Services.yaml+4 −0
Review log 2028
Show 3 earlier messages
-
Christian Kuhn updated the commit message in patch set 4 07/16/22, 10:29
-
core-ci voted on patch set 2 V +1 07/16/22, 10:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29265
-
core-ci voted on patch set 1 V -1 07/16/22, 10:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29264
-
core-ci voted on patch set 4 V +1 07/16/22, 10:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29267
-
core-ci voted on patch set 3 V +1 07/16/22, 10:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29266
-
Stefan Bürk rebased onto patch set 5 07/16/22, 12:49
-
Stefan Bürk uploaded patch set 6 07/16/22, 12:49
-
Stefan Bürk voted on patch set 6 V +1 CR +1 07/16/22, 12:51
-
core-ci voted on patch set 5 V +1 07/16/22, 12:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29276
-
core-ci voted on patch set 6 V +1 07/16/22, 12:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29277
-
Nikita Hovratov commented on patch set 6 07/16/22, 13:06
ElementBrowserInterface.php:24internal_type is gone, it's now type=folderElementBrowserInterface.php:25Here too, no internal_type anymore. -
Andreas Kienast commented on patch set 6 07/16/22, 13:13
ElementBrowserInterface.php:25Replyinternal_type=db is still a thing, as far as I can see from existing code. -
Andreas Kienast uploaded patch set 7 07/16/22, 13:14
-
Nikita Hovratov commented on patch set 7 07/16/22, 13:15
ElementBrowserInterface.php:25Replywhere? -
Christian Kuhn uploaded patch set 8 07/16/22, 13:15
-
Christian Kuhn commented on patch set 8 07/16/22, 13:15
ElementBrowserInterface.php:23ReplyDoneElementBrowserInterface.php:24ReplyDoneElementBrowserInterface.php:25ReplyDone -
Andreas Kienast commented on patch set 7 07/16/22, 13:16
ElementBrowserInterface.php:25ReplyI found this changelog entry at https://docs.typo3.org/c/typo3/cms-core/main/en-us/Changelog/11.5/Important-95384-TCAInternal_typedbOptionalForTypegroup.html and I didn't find anything that actually removed internal_type=db. -
Andreas Kienast commented on patch set 8 07/16/22, 13:18
ElementBrowserInterface.php:25ReplyYou're right, I just found the deprecation at https://docs.typo3.org/c/typo3/cms-core/main/en-us/Changelog/12.0/Deprecation-96983-TCAInternal_type.html. My apologies. -
Andreas Kienast voted on patch set 8 V +1 CR +1 07/16/22, 13:19
-
core-ci voted on patch set 7 V +1 07/16/22, 13:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29279
-
core-ci voted on patch set 8 V +1 07/16/22, 13:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29280
-
Stefan Bürk voted on patch set 8 V +1 CR +1 07/16/22, 13:27
-
Christian Kuhn commented on patch set 8 07/16/22, 13:31
ElementBrowserInterface.php:25ReplyDone -
Christian Kuhn voted on patch set 8 V +2 CR +2 07/16/22, 13:31
-
Christian Kuhn merged patch set 9 07/16/22, 13:31
ElementBrowserInterface.php:23