Review main Merged

75205[TASK] Avoid misusing element browser for link handler concerns

Christian Kuhn CR +2 V +2 Hard +148 −141 updated 07/16/22, 13:31

Commit message

This resolves a mixup in ext:recordlist:

The "Browser" classes are the "element browser" modals, used
when adding FAL images to records and when adding relations
for type="group".

The "LinkHandler" classes are a distinct construct used to
create the "t3://" syntax when linking record fields and
RTE text to a page, telephone, external URL and so on. They
are rendered as single tabs in the link handler modal.

Class LinkHandler/RecordLinkHandler allows linking to arbitrary
records. Typical example is linking to single ext:news records,
which can be configured using PageTsConfig TCEMAIN.linkHandler.

Class LinkHandler/RecordLinkHandler misuses the element browser
abstraction to list records. This materializes in class
Browser/RecordBrowser, which is not used as element browser as
such, but is just a client class of LinkHandler/RecordLinkHandler.
The two class namespaces however shouldn't interfere with
each other.

The patch resolves this by moving the code from
Browser/RecordBrowser into LinkHandler/RecordLinkHandler and
streamlining it to what is really needed. A series of changed
and added comments should improve the overall constructs
along the way.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 4

Files 15

Review log 2028

Show 3 earlier messages
  1. Christian Kuhn uploaded patch set 1 07/16/22, 10:21

  2. Christian Kuhn uploaded patch set 2 07/16/22, 10:22

  3. Christian Kuhn updated the commit message in patch set 3 07/16/22, 10:26

  1. Christian Kuhn updated the commit message in patch set 4 07/16/22, 10:29

  2. core-ci voted on patch set 2 V +1 07/16/22, 10:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29265

  3. core-ci voted on patch set 1 V -1 07/16/22, 10:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29264

  4. core-ci voted on patch set 4 V +1 07/16/22, 10:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29267

  5. core-ci voted on patch set 3 V +1 07/16/22, 10:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29266

  6. Stefan Bürk rebased onto patch set 5 07/16/22, 12:49

  7. Stefan Bürk uploaded patch set 6 07/16/22, 12:49

  8. Stefan Bürk voted on patch set 6 V +1 CR +1 07/16/22, 12:51

  9. core-ci voted on patch set 5 V +1 07/16/22, 12:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29276

  10. core-ci voted on patch set 6 V +1 07/16/22, 12:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29277

  11. Nikita Hovratov commented on patch set 6 07/16/22, 13:06

    ElementBrowserInterface.php:23

    relations

    ElementBrowserInterface.php:24

    internal_type is gone, it's now type=folder

    ElementBrowserInterface.php:25

    Here too, no internal_type anymore.
  12. Andreas Kienast commented on patch set 6 07/16/22, 13:13

    ElementBrowserInterface.php:25 Reply

    internal_type=db is still a thing, as far as I can see from existing code.
  13. Andreas Kienast uploaded patch set 7 07/16/22, 13:14

  14. Nikita Hovratov commented on patch set 7 07/16/22, 13:15

    ElementBrowserInterface.php:25 Reply

    where?
  15. Christian Kuhn uploaded patch set 8 07/16/22, 13:15

  16. Christian Kuhn commented on patch set 8 07/16/22, 13:15

    ElementBrowserInterface.php:23 Reply

    Done

    ElementBrowserInterface.php:24 Reply

    Done

    ElementBrowserInterface.php:25 Reply

    Done
  17. Andreas Kienast commented on patch set 7 07/16/22, 13:16

    ElementBrowserInterface.php:25 Reply

    I found this changelog entry at https://docs.typo3.org/c/typo3/cms-core/main/en-us/Changelog/11.5/Important-95384-TCAInternal_typedbOptionalForTypegroup.html and I didn't find anything that actually removed internal_type=db.
  18. Andreas Kienast commented on patch set 8 07/16/22, 13:18

    ElementBrowserInterface.php:25 Reply

  19. Andreas Kienast voted on patch set 8 V +1 CR +1 07/16/22, 13:19

  20. core-ci voted on patch set 7 V +1 07/16/22, 13:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29279

  21. core-ci voted on patch set 8 V +1 07/16/22, 13:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29280

  22. Stefan Bürk voted on patch set 8 V +1 CR +1 07/16/22, 13:27

  23. Christian Kuhn commented on patch set 8 07/16/22, 13:31

    ElementBrowserInterface.php:25 Reply

    Done
  24. Christian Kuhn voted on patch set 8 V +2 CR +2 07/16/22, 13:31

  25. Christian Kuhn merged patch set 9 07/16/22, 13:31