Review main Merged

75206[TASK] Raise bnf/phpstan-psr-container:^1.0.1

Christian Kuhn CR +2 V +2 Easy +10 −10 updated 07/16/22, 12:52

Commit message

Patch level raise of a monorepo --dev dependency
as yet another raise to unblock psr/container:^2.

$ composer req --dev bnf/phpstan-psr-container:^1.0.1

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 68

  1. Christian Kuhn uploaded patch set 1 07/16/22, 11:57

  2. Christian Kuhn updated the commit message in patch set 2 07/16/22, 11:59

  3. core-ci voted on patch set 2 V +1 07/16/22, 12:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29272

  4. Oliver Klee commented on patch set 2 07/16/22, 12:14

    Oh, then I'll update my PHPStan raise change to not raise this dependency.
  5. Oliver Klee voted on patch set 2 V +1 CR +1 07/16/22, 12:15

  6. core-ci commented on patch set 2 07/16/22, 12:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29273

  7. Christian Kuhn commented on patch set 2 V +2 CR +2 07/16/22, 12:52

    pre-merge and nightly green with this: will merge.
  8. Christian Kuhn merged patch set 3 07/16/22, 12:52