Review main Merged

75208[TASK] Update PHPStan

Oliver Klee CR +2 V +2 Easy +12 −17 updated 07/16/22, 13:26

Commit message

PHPStan 1.8.1 removes one warning.

Used commands:

> composer req --dev phpstan/phpstan:^1.8.1
> ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 68

  1. Oliver Klee uploaded patch set 1 07/16/22, 12:14

  2. Oliver Klee commented on patch set 1 CR -1 07/16/22, 12:16

    On it. bnf/phpstan-psr-container will be raised in a separate change, and I'll need to rebase after that anyway because the hash in the composer.lock will change.
  3. core-ci voted on patch set 1 V +1 07/16/22, 12:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29275

  4. Oliver Klee uploaded patch set 2 07/16/22, 12:59

  5. core-ci voted on patch set 2 V +1 07/16/22, 13:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29278

  6. Stefan Bürk voted on patch set 2 V +1 CR +1 07/16/22, 13:24

  7. Christian Kuhn voted on patch set 2 V +2 CR +2 07/16/22, 13:26

  8. Christian Kuhn merged patch set 3 07/16/22, 13:26